[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15827: [applet] Avoid showing a generic audio-card icon
From:       Nicolas Fella <noreply () phabricator ! kde ! org>
Date:       2018-09-29 0:41:38
Message-ID: 0e94492aa8b7c7416ff3ea1589b9bbe6 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

nicolasfella created this revision.
nicolasfella added reviewers: drosca, ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  If the hardware reports "internal" as formfactor the generic audio-card icon is \
chosen. Instead look whether the device is a sink/source and display a more specific \
icon.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  icons

REVISION DETAIL
  https://phabricator.kde.org/D15827

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/ui/DeviceListItem.qml

To: nicolasfella, drosca, ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">nicolasfella created this revision.<br />nicolasfella added \
reviewers: drosca, ngraham, broulik.<br />Herald added a project: Plasma.<br />Herald \
added a subscriber: plasma-devel.<br />nicolasfella requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15827">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>If the hardware reports \
&quot;internal&quot; as formfactor the generic audio-card icon is chosen. Instead \
look whether the device is a sink/source and display a more specific \
icon.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma \
Audio Volume Applet</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>icons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15827">https://phabricator.kde.org/D15827</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>applet/contents/code/icon.js<br /> \
applet/contents/ui/DeviceListItem.qml</div></div></div><br /><div><strong>To: \
</strong>nicolasfella, drosca, ngraham, broulik<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]