[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12498: Fully remove `Application Name` from Details panel
From:       Stefan_Brüns <noreply () phabricator ! kde ! org>
Date:       2018-09-28 21:47:46
Message-ID: 5aad2e454eabb6fedc8cf1482b42e6a3 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

bruns added a comment.


  In D12498#333627 <https://phabricator.kde.org/D12498#333627>, @sharvey wrote:
  
  > I believe what you're perceiving in the XML file is in fact the result of a lot \
of changes made to the layout. Unneeded columns, rows, and spacers were deleted, \
causing "gaps" in the old XML file. In places, I added options like column spans and \
justifications. The XML file changed a lot.  
  
  The diffstat for the file I attached is:
  9 changed lines
  26 removed lines
  6 added lines

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D12498#333627" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D12498#333627</a>, <a \
href="https://phabricator.kde.org/p/sharvey/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@sharvey</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I believe what you&#039;re perceiving in the \
XML file is in fact the result of a lot of changes made to the layout. Unneeded \
columns, rows, and spacers were deleted, causing &quot;gaps&quot; in the old XML \
file. In places, I added options like column spans and justifications. The XML file \
changed a lot.</p></div> </blockquote>

<p>The diffstat for the file I attached is:<br />
9 changed lines<br />
26 removed lines<br />
6 added lines</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R121 \
Policykit (Polkit) KDE Agent</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br \
/><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]