[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15815: Remove expensive blocking call on plasmashell startup
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-09-28 14:03:36
Message-ID: d13c58c5167fd65f1a968e10122934bc () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  QDBusInterface is a blocking call that calls introspect. We don't need
  to introspect.
  
  As this is called on startup this call starts kuiserver, which means
  plasma is blocked whilst a whole process spawns, this is a lot worse
  than just a regular, ~100ms on my system
  
  Also using the generated versions is generally neater to read.

TEST PLAN
  Restarted plasmashell
  Copied a file
  Still had a spinny wheel
  Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 doesn't list kuiserver

REPOSITORY
  R120 Plasma Workspace

BRANCH
  kuiserver_startup

REVISION DETAIL
  https://phabricator.kde.org/D15815

AFFECTED FILES
  dataengines/applicationjobs/CMakeLists.txt
  dataengines/applicationjobs/kuiserverengine.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a \
subscriber: plasma-devel.<br />davidedmundson requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15815">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>QDBusInterface is a blocking call \
that calls introspect. We don&#039;t need<br /> to introspect.</p>

<p>As this is called on startup this call starts kuiserver, which means<br />
plasma is blocked whilst a whole process spawns, this is a lot worse<br />
than just a regular, ~100ms on my system</p>

<p>Also using the generated versions is generally neater to read.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Restarted plasmashell<br /> Copied a file<br \
/> Still had a spinny wheel<br />
Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 doesn&#039;t list \
kuiserver</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>kuiserver_startup</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15815">https://phabricator.kde.org/D15815</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>dataengines/applicationjobs/CMakeLists.txt<br /> \
dataengines/applicationjobs/kuiserverengine.cpp</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]