View Revision
mart added a comment.

Api looks improved to me..
still some todo pieces, but looks good to me


INLINE COMMENTS
View Inlinetaskgroupingproxymodel.cpp:724
} else if (role == AbstractTasksModel::VirtualDesktop) {
// Returns the lowest virtual desktop id among all children of the
// group.
} else if (role == AbstractTasksModel::VirtualDesktops) {
// FIXME WAYLAND Similar to activities
// // Returns the lowest virtual desktop id among all children of the

what's the rationale of this dead code?


View Inlinexwindowtasksmodel.cpp:633
} else if (role == VirtualDesktop) {
return d->windowInfo(window)->desktop();
} else if (role == VirtualDesktops) {
return QVariantList() << d->windowInfo(window)->desktop();
} else if (role == IsOnAllVirtualDesktops) {

{} initializer?


REPOSITORY
R120 Plasma Workspace

REVISION DETAIL
https://phabricator.kde.org/D13745

To: hein, mart, mvourlakos
Cc: anthonyfieroni, zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart