[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12498: Fully remove `Application Name` from Details panel
From:       Scott Harvey <noreply () phabricator ! kde ! org>
Date:       2018-09-29 10:20:32
Message-ID: 05c8ea39ecf99f5040b5b0703f584c4a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sharvey added a comment.


  @ngraham : Now that I understand what went wrong here, I really do think this \
particular diff be abandoned. It mistakenly contains unrelated material from a \
different diff (D12311 <https://phabricator.kde.org/D12311>) - which we probably \
shouldn't re-submit. I will get a fresh master, which will have D12311 \
<https://phabricator.kde.org/D12311> already incorporated and make @bruns 's small \
change. That should resolve the issue without any drama.  
  My weekend is booked solid, but I'll try to squeeze it in.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">sharvey added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br \
/><div><div><p><a href="https://phabricator.kde.org/p/ngraham/" style="  \
border-color: #f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> : Now that I understand what went wrong \
here, I really do think this particular diff be abandoned. It mistakenly contains \
unrelated material from a different diff (<a \
href="https://phabricator.kde.org/D12311" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D12311</a>) - which we \
probably shouldn&#039;t re-submit. I will get a fresh master, which will have <a \
href="https://phabricator.kde.org/D12311" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D12311</a> already \
incorporated and make <a href="https://phabricator.kde.org/p/bruns/" style="  \
border-color: #f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@bruns</a> &#039;s small change. That should resolve \
the issue without any drama.</p>

<p>My weekend is booked solid, but I&#039;ll try to squeeze it in.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R121 Policykit (Polkit) KDE \
Agent</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br \
/><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]