[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support
From: Marco Martin <noreply () phabricator ! kde ! org>
Date: 2018-09-28 16:01:25
Message-ID: e1efa67a4b69f817c4586b5a66286772 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> pagermodel.cpp:444
> for (auto windowModel : d->windowModels) {
> - windowModel->setVirtualDesktop(0);
> + windowModel->setVirtualDesktop();
>
would it be possible to avoid default arguments?
> pagermodel.cpp:642
> + if (!winIds.isEmpty() && winIds.at(0).toUInt() == id) {
> + tasksModel->requestVirtualDesktops(idx, QVariantList() << \
> itemId.toString()); + break;
{} initializer?
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13748
To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">mart accepted this revision.<br />mart added inline \
comments.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13748">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13748#inline-85560">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">pagermodel.cpp:444</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: \
#aa4000">auto</span> <span style="color: #a0a000">windowModel</span> <span \
class="p">:</span> <span class="n">d</span><span style="color: \
#aa2211">-></span><span class="n">windowModels</span><span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);"> <span class="n">windowModel</span><span \
style="color: #aa2211">-></span><span class="n">setVirtualDesktop</span><span \
class="p">(<span class="bright"></span></span><span class="bright"></span><span \
style="color: #601200"><span class="bright">0</span></span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">windowModel</span><span style="color: \
#aa2211">-></span><span class="n">setVirtualDesktop</span><span \
class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">would it be possible to avoid default arguments?</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13748#inline-85561">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">pagermodel.cpp:642</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">winIds</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">()</span> <span style="color: \
#aa2211">&&</span> <span class="n">winIds</span><span class="p">.</span><span \
class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span \
class="p">).</span><span class="n">toUInt</span><span class="p">()</span> <span \
style="color: #aa2211">==</span> <span class="n">id</span><span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span \
class="n">tasksModel</span><span style="color: #aa2211">-></span><span \
class="n">requestVirtualDesktops</span><span class="p">(</span><span \
class="n">idx</span><span class="p">,</span> <span class="n">QVariantList</span><span \
class="p">()</span> <span style="color: #aa2211"><<</span> <span \
class="n">itemId</span><span class="p">.</span><span class="n">toString</span><span \
class="p">());</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">break</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">{} \
initializer?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13748">https://phabricator.kde.org/D13748</a></div></div><br \
/><div><strong>To: </strong>hein, mart<br /><strong>Cc: </strong>plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic