[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15789: Support QXL hotplug_mode_update
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2018-09-28 16:29:53
Message-ID: 4f69cccbe68d8f4952c49e4bab410493 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in xrandroutput.cpp:212
> why are we querying if the property exists rather than if the property is 1?

Because it's poorly specified. In fact, it's always 0 as far as I can tell.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D15789

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">apol marked an inline comment as done.<br />apol added inline \
comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15789">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15789#inline-85479">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">xrandroutput.cpp:212</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">why are we querying if the property exists rather than if the property is \
1?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Because it&#039;s poorly specified. In fact, it&#039;s always 0 as far \
as I can tell.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R110 KScreen Library</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15789">https://phabricator.kde.org/D15789</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]