[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12498: Fully remove `Application Name` from Details panel
From:       Scott Harvey <noreply () phabricator ! kde ! org>
Date:       2018-09-28 21:06:24
Message-ID: bdb9759bb767bfba6d4cd08ff4aaea8d () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sharvey added a comment.


  I believe what you're perceiving in the XML file is in fact the result of a lot of \
changes made to the layout. Unneeded columns, rows, and spacers were deleted, causing \
"gaps" in the old XML file. In places, I added options like column spans and \
justifications. The XML file changed a lot.  
  In my opinion - which you can take or leave - I don't believe these XML files were \
intended to be human-read. The UI they generate is where the judgement and checking \
should come from, not the convoluted XML generated by QtCreator. I've seen diffs much \
larger than this one.  
  Truthfuly, I'm not clear on what you expect me to do. The UI works fine. Monkeying \
with the XML to make it "pretty" seems a bit pointless.  
  I've got an email chain of 48 messages for a simple string change. And I expect \
it's only going to grow. This has been nitpicked to death, and I'm not sure why. \
We've beaten this dead horse to a pulp.  
  @bruns - If you know what you want done with the XML file, I'll gladly let you do \
it. I simply don't get it.  
  @ngraham  - You know I'm not combative or confrontational by nature. But this is \
beyond my understanding.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">sharvey added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br \
/><div><div><p>I believe what you&#039;re perceiving in the XML file is in fact the \
result of a lot of changes made to the layout. Unneeded columns, rows, and spacers \
were deleted, causing &quot;gaps&quot; in the old XML file. In places, I added \
options like column spans and justifications. The XML file changed a lot.</p>

<p>In my opinion - which you can take or leave - I don&#039;t believe these XML files \
were intended to be human-read. The UI they generate is where the judgement and \
checking should come from, not the convoluted XML generated by QtCreator. I&#039;ve \
seen diffs much larger than this one.</p>

<p>Truthfuly, I&#039;m not clear on what you expect me to do. The UI works fine. \
Monkeying with the XML to make it &quot;pretty&quot; seems a bit pointless.</p>

<p>I&#039;ve got an email chain of 48 messages for a simple string change. And I \
expect it&#039;s only going to grow. This has been nitpicked to death, and I&#039;m \
not sure why. We&#039;ve beaten this dead horse to a pulp.</p>

<p><a href="https://phabricator.kde.org/p/bruns/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@bruns</a> - If you know what you want done with the \
XML file, I&#039;ll gladly let you do it. I simply don&#039;t get it.</p>

<p><a href="https://phabricator.kde.org/p/ngraham/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a>  - You know I&#039;m not combative or \
confrontational by nature. But this is beyond my understanding.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R121 Policykit (Polkit) KDE \
Agent</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br \
/><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]