[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D15423: System settings: make date/time format preview consistent
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-09-28 11:28:28
Message-ID: 29ad2ae17b4c85d7f7dd2fb65a3c18dd () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
davidedmundson added inline comments.
INLINE COMMENTS
> kcmformats.cpp:322
> + str = m_ui->comboNumbers->currentData().toString();
> + nloc = str.isEmpty() ? QLocale(glob) : QLocale(str);
> +
I don't understand, why is this sometimes empty?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D15423
To: McPain, hein, #vdg
Cc: davidedmundson, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15423">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15423#inline-85493">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kcmformats.cpp:322</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> \
<span class="p">(</span><span class="n">useDetailed</span><span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span \
class="bright">nloc</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">=</span></span><span class="bright"> </span><span \
class="n"><span class="bright">QLocale</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="n">m_ui</span><span \
style="color: #aa2211">-></span><span class="n">comboNumbers</span><span \
style="color: #aa2211">-></span><span class="n">currentData</span><span \
class="p">().</span><span class="n">toString</span><span class="p">(<span \
class="bright">)</span>);</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span \
class="n"><span class="bright">t</span>loc</span> <span style="color: \
#aa2211">=</span> <span class="n">QLocale</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">m_ui</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-></span></span><span class="bright"></span><span \
class="n"><span class="bright">comboTime</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">currentData</span></span><span class="bright"></span><span \
class="p"><span class="bright">().</span></span><span class="bright"></span><span \
class="n"><span class="bright">toString</span></span><span \
class="bright"></span><span class="p"><span class="bright">()</span>);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="bright"></span><span class="n"><span \
class="bright">str</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">=</span></span><span class="bright"> </span><span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">comboNumbers</span><span style="color: #aa2211">-></span><span \
class="n">currentData</span><span class="p">().</span><span \
class="n">toString</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="bright"></span><span class="n"><span class="bright">n</span>loc</span> <span \
style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span \
class="bright">str</span></span><span class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span class="n"><span \
class="bright">isEmpty</span></span><span class="bright"></span><span class="p"><span \
class="bright">()</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">?</span></span><span class="bright"> </span><span \
class="n">QLocale</span><span class="p">(<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span class="bright">glob</span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">:</span></span><span class="bright"> </span><span class="n"><span \
class="bright">QLocale</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span class="n"><span \
class="bright">str</span></span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
don't understand, why is this sometimes \
empty?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15423">https://phabricator.kde.org/D15423</a></div></div><br \
/><div><strong>To: </strong>McPain, hein, VDG<br /><strong>Cc: \
</strong>davidedmundson, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic