[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15644: Provide option to hide menu bar for Ksysguard
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-09-27 13:25:16
Message-ID: ede304353b55c2be92657e094af81fca () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham added a comment.


  Awesome job, @lsartorelli. For your next trick, would you like to create \
`KStandardAction::showMenubarWithWarning` (or something like that)? This would \
essentially duplicate the code you've written here, but it would be in a new central \
location so we could ensure consistency between apps, and make changes in only one \
place rather than //n// places. Then we could start to port KSysGuard, Kate, Gwenview \
to use it--and also adopt it for some of the remaining apps that don't currently show \
a warning, like Konsole.  
  The relevant code is in \
https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n619. Wanna have \
a go at it?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15644">View Revision</a></tr></table><br \
/><div><div><p>Awesome job, <a href="https://phabricator.kde.org/p/lsartorelli/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@lsartorelli</a>. For your next trick, would you \
like to create <tt style="background: #ebebeb; font-size: \
13px;">KStandardAction::showMenubarWithWarning</tt> (or something like that)? This \
would essentially duplicate the code you&#039;ve written here, but it would be in a \
new central location so we could ensure consistency between apps, and make changes in \
only one place rather than <em>n</em> places. Then we could start to port KSysGuard, \
Kate, Gwenview to use it--and also adopt it for some of the remaining apps that \
don&#039;t currently show a warning, like Konsole.</p>

<p>The relevant code is in <a \
href="https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n619" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n619</a>. \
Wanna have a go at it?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R106 KSysguard</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15644">https://phabricator.kde.org/D15644</a></div></div><br \
/><div><strong>To: </strong>lsartorelli, ngraham, Plasma, Frameworks, sitter<br \
/><strong>Cc: </strong>broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]