[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D15304: [KCM] Port (almost) entirely to QQC2
From: David Rosca <noreply () phabricator ! kde ! org>
Date: 2018-09-27 14:08:44
Message-ID: a78ba6896e494a9f4fe2f543dd8ce804 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
drosca added a comment.
In D15304#332755 <https://phabricator.kde.org/D15304#332755>, @ngraham wrote:
> > Plasma items should not be used in KCM.
>
> Hmm, what you you recommend then for showing an icon item? The old `QIconItem` \
breaks for fractional scale factors. Kirigami has a nice icon, but then we'd need to \
import Kirigami.
I suggest to fix QIconItem, as it is used in other places too.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D15304
To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">drosca added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15304">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D15304#332755" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D15304#332755</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>Plasma items should not be used in \
KCM.</p></blockquote>
<p>Hmm, what you you recommend then for showing an icon item? The old <tt \
style="background: #ebebeb; font-size: 13px;">QIconItem</tt> breaks for fractional \
scale factors. Kirigami has a nice icon, but then we'd need to import \
Kirigami.</p></div> </blockquote>
<p>I suggest to fix QIconItem, as it is used in other places too.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15304">https://phabricator.kde.org/D15304</a></div></div><br \
/><div><strong>To: </strong>ngraham, Plasma, drosca<br /><strong>Cc: \
</strong>nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic