[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15304: [KCM] Port (almost) entirely to QQC2
From:       David Rosca <noreply () phabricator ! kde ! org>
Date:       2018-09-27 7:42:51
Message-ID: 9c4fd98b522b875042e55d48404c4e91 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

drosca added inline comments.

INLINE COMMENTS

> CardListItem.qml:33
> RowLayout {
> -        QIconItem {
> +        PlasmaCore.IconItem {
> id: clientIcon

Plasma items should not be used in KCM.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">drosca added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15304">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15304#inline-85366">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">CardListItem.qml:33</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">    <span style="color: \
#004012">RowLayout</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span \
class="bright"></span><span style="color: #004012"><span \
class="bright">Q</span>IconItem</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="bright"></span><span style="color: #004012"><span \
class="bright">PlasmaCore</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span style="color: \
#004012">IconItem</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">            <span style="color: #aa4000">id: clientIcon</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Plasma items should not be used in \
KCM.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15304">https://phabricator.kde.org/D15304</a></div></div><br \
/><div><strong>To: </strong>ngraham, Plasma, drosca<br /><strong>Cc: \
</strong>nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]