[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15333: Group Widget + Color Picker = Widget Out Of Bounds
From:       Oleg Solovyov <noreply () phabricator ! kde ! org>
Date:       2018-09-27 8:20:38
Message-ID: 55b83f51db26273312afc28933d2b28a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

McPain added inline comments.

INLINE COMMENTS

> main.qml:138
> 
> -            readonly property int thickness: Math.ceil(Math.min(parent.width, \
> parent.height) / units.iconSizes.small) 

We need to make thickness independent from length.

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">McPain added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15333">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15333#inline-85372">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:138</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">          \
<span style="color: #004012">readonly</span> <span style="color: \
#004012">property</span> <span style="color: #304a96">int</span> <span style="color: \
#aa4000">thickness:</span> <span style="color: #304a96">Math</span><span \
class="p">.</span><span style="color: #004012">ceil</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#304a96"><span class="bright">Math</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">min</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">parent</span></span><span class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">width</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">parent</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">height</span></span><span class="bright"></span><span class="p"><span \
class="bright">)</span></span> <span style="color: #aa2211">/</span> <span \
style="color: #004012">units</span><span class="p">.</span><span style="color: \
#004012">iconSizes</span><span class="p">.</span><span style="color: \
#004012">small</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: \
#004012">readonly</span> <span style="color: #004012">property</span> <span \
style="color: #304a96">int</span> <span style="color: #aa4000">thickness:</span> \
<span style="color: #304a96">Math</span><span class="p">.</span><span style="color: \
#004012">ceil</span><span class="p">(<span class="bright"></span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">buttonSize</span></span> <span style="color: #aa2211">/</span> <span \
style="color: #004012">units</span><span class="p">.</span><span style="color: \
#004012">iconSizes</span><span class="p">.</span><span style="color: \
#004012">small</span><span class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We \
need to make thickness independent from length.</p></div></div></div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15333">https://phabricator.kde.org/D15333</a></div></div><br \
/><div><strong>To: </strong>McPain, Plasma, ngraham<br /><strong>Cc: \
</strong>davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]