[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15769: Show "muted" icon in panel and disable shortcuts for Dummy Output
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-09-26 14:12:28
Message-ID: 084fe543a76c16e8db2d4feaaf241b71 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik created this revision.
broulik added reviewers: Plasma, drosca, nicolasfella, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The "Dummy Output" doesn't play any sound, so indicate that in the panel.
  Also disable the volume shortcuts in this case.

TEST PLAN
  The slider in the popup alongside "Dummy Output" is still there and can be \
interacted with, should an application rely on the fact that it's not muted or \
something like that? Can still be addressed separately  
  - Disconnected my headphones. Got an OSD saying "dummy output" is now the current \
device and my panel showed a constant "muted" icon, pressing volume keys or wheeling \
                the icon would do nothing
  - Connected my headphones. Tray icon reflected default output volume, pressing \
volume keys and wheeling the icon would change the volume

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15769

AFFECTED FILES
  applet/contents/ui/main.qml

To: broulik, #plasma, drosca, nicolasfella, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, drosca, nicolasfella, ngraham.<br />Herald added a project: Plasma.<br \
/>Herald added a subscriber: plasma-devel.<br />broulik requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15769">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>The &quot;Dummy Output&quot; \
doesn&#039;t play any sound, so indicate that in the panel.<br /> Also disable the \
volume shortcuts in this case.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>The slider in the popup alongside &quot;Dummy Output&quot; is \
still there and can be interacted with, should an application rely on the fact that \
it&#039;s not muted or something like that? Can still be addressed separately</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Disconnected my headphones. Got an OSD saying \
&quot;dummy output&quot; is now the current device and my panel showed a constant \
&quot;muted&quot; icon, pressing volume keys or wheeling the icon would do \
nothing</li> <li class="remarkup-list-item">Connected my headphones. Tray icon \
reflected default output volume, pressing volume keys and wheeling the icon would \
change the volume</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15769">https://phabricator.kde.org/D15769</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applet/contents/ui/main.qml</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, drosca, nicolasfella, ngraham<br \
/><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]