[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15304: [KCM] Port (almost) entirely to QQC2
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-09-26 15:22:28
Message-ID: 207adba0a17d5a2d37bc87fc2c4afd2a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham planned changes to this revision.
ngraham added a comment.


  In D15304#332274 <https://phabricator.kde.org/D15304#332274>, @drosca wrote:
  
  > There is `ScrollView` in QQC2 (since Qt 5.9), so please use it.
  
  
  Ah, I see now that it's only available in QQC 2.2 and later. Will do.
  
  > Also as @davidedmundson said, please edit the commit message.
  
  The commit message from from the patch title, which is now `[KCM] Port (almost) \
entirely to QQC2`. Does that still need adjustment?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham planned changes to this revision.<br />ngraham added \
a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15304">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D15304#332274" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D15304#332274</a>, <a \
href="https://phabricator.kde.org/p/drosca/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@drosca</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>There is <tt style="background: #ebebeb; \
font-size: 13px;">ScrollView</tt> in QQC2 (since Qt 5.9), so please use it.</p></div> \
</blockquote>

<p>Ah, I see now that it&#039;s only available in QQC 2.2 and later. Will do.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also \
as <a href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: \
#f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidedmundson</a> said, please edit the commit \
message.</p></blockquote>

<p>The commit message from from the patch title, which is now <tt style="background: \
#ebebeb; font-size: 13px;">[KCM] Port (almost) entirely to QQC2</tt>. Does that still \
need adjustment?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 \
Plasma Audio Volume Applet</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15304">https://phabricator.kde.org/D15304</a></div></div><br \
/><div><strong>To: </strong>ngraham, Plasma, drosca<br /><strong>Cc: \
</strong>nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]