[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D15093: Add WireGuard capability.
From: Pino Toscano <noreply () phabricator ! kde ! org>
Date: 2018-09-18 5:41:32
Message-ID: cf30b20ee4707d7d652fd5a2c686e531 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.
note there are still few "not done" comments around (eg using QSpinBox for fwMark)
INLINE COMMENTS
> CMakeLists.txt:28
> Widgets
> + Test
> )
already added by D15520: Upgrade SimpleIpV4AddressValidator and \
SimpleIpV6AddressValidator <https://phabricator.kde.org/D15520>
> wireguard.cpp:139
> +
> + WireGuardKeyValidator keyValidator(this);
> + int keyPos = 0;
no need to specify `this` as parent, since it is on stack, and thus it will be \
deleted automatically
> wireguard.cpp:139-140
> +
> + WireGuardKeyValidator keyValidator(this);
> + int keyPos = 0;
> +
indent
> wireguard.cpp:177
> + if (!value.isEmpty()) {
> + int pos = 0;
> + SimpleIpListValidator validator(this,
since earlier there is a `keyPos` variable used for basically the same purpose (i.e. \
passing it to the `validate()` of validators), just move `pos` earlier in the \
function, and use one everywhere
> wireguardadvancedwidget.cpp:26
> +
> +#include <QStandardPaths>
> +#include <QUrl>
unused
> wireguardadvancedwidget.cpp:31
> +#include <KLocalizedString>
> +#include <KProcess>
> +#include <KAcceleratorManager>
unused
> wireguardadvancedwidget.cpp:120
> + NMStringMap data;
> + long intVal;
> + QString stringVal;
a bit confusing to call `intVal` a variable which is (not correctly) a long; OTOH, it \
can be removed altogether (see below)
> wireguardadvancedwidget.cpp:121
> + long intVal;
> + QString stringVal;
> +
unused
> wireguardadvancedwidget.cpp:123-127
> + intVal = m_ui->listenPortSpinBox->value();
> + setOrClear(data, QLatin1String(NM_WG_KEY_LISTEN_PORT), intVal);
> +
> + intVal = m_ui->mtuSpinBox->value();
> + setOrClear(data, QLatin1String(NM_WG_KEY_MTU), intVal);
just inline the calls to `value()`, just like done below
> wireguardadvancedwidget.h:27
> +#include <QDialog>
> +#include <QProcess>
> +
unused
> wireguardkeyvalidator.h:26
> +
> +class Q_DECL_EXPORT WireGuardKeyValidator : public QValidator
> +{
no need for `Q_DECL_EXPORT`, as it is in a plugin, and thus it does not need to be \
exported as public symbol
> pino wrote in wireguardwidget.cpp:182
> no need for the (...) for the whole condition:
>
> return foo || bar;
>
> is easier than
>
> return (foo || bar);
this is not "done", btw
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D15093
To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">pino requested changes to this revision.<br />pino added a \
comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15093">View \
Revision</a></tr></table><br /><div><div><p>note there are still few "not \
done" comments around (eg using QSpinBox for fwMark)</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84020">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:28</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> Widgets </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> Test </div><div \
style="padding: 0 8px; margin: 0 4px; ">) </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">already added by <a href="https://phabricator.kde.org/D15520" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D15520: Upgrade \
SimpleIpV4AddressValidator and SimpleIpV6AddressValidator</a></p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84022">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">wireguard.cpp:139</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">WireGuardKeyValidator</span> <span class="n">keyValidator</span><span \
class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">int</span> <span class="n">keyPos</span> \
<span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no \
need to specify <tt style="background: #ebebeb; font-size: 13px;">this</tt> as \
parent, since it is on stack, and thus it will be deleted \
automatically</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84021">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">wireguard.cpp:139-140</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">WireGuardKeyValidator</span> <span class="n">keyValidator</span><span \
class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">int</span> <span class="n">keyPos</span> \
<span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">indent</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84023">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">wireguard.cpp:177</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">value</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">int</span> <span class="n">pos</span> \
<span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">SimpleIpListValidator</span> <span \
style="color: #004012">validator</span><span class="p">(</span><span style="color: \
#aa4000">this</span><span class="p">,</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">since earlier there is a <tt style="background: #ebebeb; font-size: \
13px;">keyPos</tt> variable used for basically the same purpose (i.e. passing it to \
the <tt style="background: #ebebeb; font-size: 13px;">validate()</tt> of validators), \
just move <tt style="background: #ebebeb; font-size: 13px;">pos</tt> earlier in the \
function, and use one everywhere</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84024">View Inline</a><span \
style="color: #4b4d51; font-weight: \
bold;">wireguardadvancedwidget.cpp:26</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: \
#304a96">#include</span> <span class="cpf"><QStandardPaths></span><span \
style="color: #304a96"></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> \
<span class="cpf"><QUrl></span><span style="color: #304a96"></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">unused</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84026">View Inline</a><span \
style="color: #4b4d51; font-weight: \
bold;">wireguardadvancedwidget.cpp:31</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: \
#304a96">#include</span> <span class="cpf"><KLocalizedString></span><span \
style="color: #304a96"></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> \
<span class="cpf"><KProcess></span><span style="color: #304a96"></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #304a96">#include</span> <span \
class="cpf"><KAcceleratorManager></span><span style="color: #304a96"></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">unused</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84029">View Inline</a><span \
style="color: #4b4d51; font-weight: \
bold;">wireguardadvancedwidget.cpp:120</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">NMStringMap</span> <span class="n">data</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">long</span> <span class="n">intVal</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span \
class="n">stringVal</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">a \
bit confusing to call <tt style="background: #ebebeb; font-size: 13px;">intVal</tt> a \
variable which is (not correctly) a long; OTOH, it can be removed altogether (see \
below)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D15093#inline-84030">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">wireguardadvancedwidget.cpp:121</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">long</span> <span class="n">intVal</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">QString</span> <span class="n">stringVal</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">unused</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84031">View Inline</a><span \
style="color: #4b4d51; font-weight: \
bold;">wireguardadvancedwidget.cpp:123-127</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">intVal</span> <span style="color: #aa2211">=</span> <span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">listenPortSpinBox</span><span style="color: #aa2211">-></span><span \
class="n">value</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">setOrClear</span><span class="p">(</span><span class="n">data</span><span \
class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span \
class="n">NM_WG_KEY_LISTEN_PORT</span><span class="p">),</span> <span \
class="n">intVal</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">intVal</span> <span style="color: #aa2211">=</span> <span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">mtuSpinBox</span><span style="color: #aa2211">-></span><span \
class="n">value</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">setOrClear</span><span class="p">(</span><span class="n">data</span><span \
class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span \
class="n">NM_WG_KEY_MTU</span><span class="p">),</span> <span \
class="n">intVal</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">just \
inline the calls to <tt style="background: #ebebeb; font-size: 13px;">value()</tt>, \
just like done below</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84025">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">wireguardadvancedwidget.h:27</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"><span style="color: #304a96">#include</span> <span \
class="cpf"><QDialog></span><span style="color: #304a96"></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#include</span> <span class="cpf"><QProcess></span><span \
style="color: #304a96"></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">unused</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-84032">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">wireguardkeyvalidator.h:26</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"><span class="n">class</span> <span class="n">Q_DECL_EXPORT</span> <span \
style="color: #a0a000">WireGuardKeyValidator</span> <span class="p">:</span> <span \
class="n">public</span> <span class="n">QValidator</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">no need for <tt style="background: #ebebeb; font-size: \
13px;">Q_DECL_EXPORT</tt>, as it is in a plugin, and thus it does not need to be \
exported as public symbol</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-82763">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">pino</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">wireguardwidget.cpp:182</span></div> <div style="margin: \
8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">no need \
for the (...) for the whole condition:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: \
#aa4000">return</span> <span class="n">foo</span> <span style="color: \
#aa2211">||</span> <span class="n">bar</span><span class="p">;</span></pre></div>
<p style="padding: 0; margin: 8px;">is easier than</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: \
#aa4000">return</span> <span class="p">(</span><span class="n">foo</span> <span \
style="color: #aa2211">||</span> <span class="n">bar</span><span \
class="p">);</span></pre></div></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">this is not "done", \
btw</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15093">https://phabricator.kde.org/D15093</a></div></div><br \
/><div><strong>To: </strong>andersonbruce, Plasma, jgrulich, pino<br /><strong>Cc: \
</strong>acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic