[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15093: Add WireGuard capability.
From:       Bruce Anderson <noreply () phabricator ! kde ! org>
Date:       2018-09-16 7:59:53
Message-ID: e870a0bdc857b9bde73a95d3f3df3190 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

andersonbruce marked 45 inline comments as done.
andersonbruce added inline comments.

INLINE COMMENTS

> pino wrote in wireguard.cpp:121
> better use qt's foreach here:
> 
> Q_FOREACH (const QString &address, valueList)
> 
> and then using `address` instead of `valueList[i]`

Used plain 'for' instead because Nathaniel Graham commented that the Q_FOREACH is not \
acceptable anymore.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">andersonbruce marked 45 inline comments as done.<br \
/>andersonbruce added inline comments. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15093">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-82748">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">pino</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">wireguard.cpp:121</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">better use \
qt&#039;s foreach here:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span \
class="n">Q_FOREACH</span> <span class="p">(</span><span style="color: \
#aa4000">const</span> <span class="n">QString</span> <span style="color: \
#aa2211">&amp;</span><span class="n">address</span><span class="p">,</span> <span \
class="n">valueList</span><span class="p">)</span></pre></div>

<p style="padding: 0; margin: 8px;">and then using <tt style="background: #ebebeb; \
font-size: 13px;">address</tt> instead of <tt style="background: #ebebeb; font-size: \
13px;">valueList[i]</tt></p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">Used plain &#039;for&#039; instead because \
Nathaniel Graham commented that the Q_FOREACH is not acceptable \
anymore.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15093">https://phabricator.kde.org/D15093</a></div></div><br \
/><div><strong>To: </strong>andersonbruce, Plasma, jgrulich, pino<br /><strong>Cc: \
</strong>acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]