[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15514: [libbreezecommon] Use box blur instead of FFT approach
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-09-14 20:53:20
Message-ID: 736adc00892ce8d6d1eabb1ddd8108d9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

zzag added a comment.


  In D15514#326127 <https://phabricator.kde.org/D15514#326127>, @ngraham wrote:
  
  > Yeah, I also can't tell the difference. If this new way is computationally \
cheaper, then +1 from me.  
  
  I don't want to say numbers (because in order to have proper benchmark, I have to \
test it on variety of different hardware), but with the debug build (on my crappy \
2012 laptop) + some load (Firefox), on average, it takes 10x less time to generate \
shadows.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15514">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D15514#326127" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D15514#326127</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Yeah, I also can&#039;t tell the difference. \
If this new way is computationally cheaper, then +1 from me.</p></div> </blockquote>

<p>I don&#039;t want to say numbers (because in order to have proper benchmark, I \
have to test it on variety of different hardware), but with the debug build (on my \
crappy 2012 laptop) + some load (Firefox), on average, it takes 10x less time to \
generate shadows.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 \
Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15514">https://phabricator.kde.org/D15514</a></div></div><br \
/><div><strong>To: </strong>zzag, KWin, Plasma<br /><strong>Cc: </strong>ngraham, \
abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]