[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15357: [Bookmarks Runner] Remove duplicate results for bookmarks
From:       Stefan_Brüns <noreply () phabricator ! kde ! org>
Date:       2018-09-09 15:46:04
Message-ID: f1e4a1dc50945347746c05c1bf64088a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

bruns added a comment.


  In D15357#322812 <https://phabricator.kde.org/D15357#322812>, @davidedmundson \
wrote:  
  > RunnerContext::addMatches has its own duplicate check based on match.id
  >
  > We're not explicitly setting that currently.
  >  I think we can just do  match.setId(url+title); and have everything handled \
auto-magically.  >
  > If that does work it will be less code with the same results, faster and even \
handle dupes in both firefox and chrome bookmarks. Win win.  
  
  hm, no:
  
  - It will not filter out the entries with empty titles
  - The BookmarkMatch constructor fetches the favicon for each match

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15357">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D15357#322812" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D15357#322812</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>RunnerContext::addMatches has its own \
duplicate check based on match.id</p>

<p>We&#039;re not explicitly setting that currently.<br />
 I think we can just do  match.setId(url+title); and have everything handled \
auto-magically.</p>

<p>If that does work it will be less code with the same results, faster and even \
handle dupes in both firefox and chrome bookmarks. Win win.</p></div> </blockquote>

<p>hm, no:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">It will not filter out the entries with empty \
titles</li> <li class="remarkup-list-item">The BookmarkMatch constructor fetches the \
favicon for each match</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15357">https://phabricator.kde.org/D15357</a></div></div><br \
/><div><strong>To: </strong>bruns, Plasma<br /><strong>Cc: </strong>davidedmundson, \
zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]