[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15093: Add WireGuard capability.
From:       Bruce Anderson <noreply () phabricator ! kde ! org>
Date:       2018-09-06 4:32:57
Message-ID: 4b62139e76240b9ba539e66894d0b7e4 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

andersonbruce added inline comments.

INLINE COMMENTS

> jgrulich wrote in wireguard.cpp:71
> You can use simpleipv[4,6]validator we have in plasma-nm instead of using \
> everything below. Or maybe QHostAddress can validate it for you?

The problem with using the simpleipv[4,6]validator is that WireGuard requires that in \
some cases the IP address can include a CIDR at the end (e.g. 10.2.4.6/32) and in \
another case the entry needs to have a port number (e.g. 10.2.3.5:7642) and the \
simpleip* functions won't handle either of these as currently written. QHostAddress \
will handle the CIDR but not the port number version. Also I'm not really thrilled \
with how QHostAddress does its verification. I know that it is technically correct \
but my personal opinion is that "1/32" should not be accepted as a valid IPv4 address \
which QHostAddress does.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">andersonbruce added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15093">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15093#inline-81721">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">jgrulich</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">wireguard.cpp:71</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">You can use simpleipv[4,6]validator we have in plasma-nm instead of using \
everything below. Or maybe QHostAddress can validate it for you?</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The \
problem with using the simpleipv[4,6]validator is that WireGuard requires that in \
some cases the IP address can include a CIDR at the end (e.g. 10.2.4.6/32) and in \
another case the entry needs to have a port number (e.g. 10.2.3.5:7642) and the \
simpleip* functions won&#039;t handle either of these as currently written. \
QHostAddress will handle the CIDR but not the port number version. Also I&#039;m not \
really thrilled with how QHostAddress does its verification. I know that it is \
technically correct but my personal opinion is that &quot;1/32&quot; should not be \
accepted as a valid IPv4 address which QHostAddress \
does.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15093">https://phabricator.kde.org/D15093</a></div></div><br \
/><div><strong>To: </strong>andersonbruce, Plasma, jgrulich, pino<br /><strong>Cc: \
</strong>acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]