[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15011: [Kickoff] Make the search field always look like a search field
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-09-05 20:59:41
Message-ID: 752eb919d5ab54b6d168d0e76657b2e0 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham added a comment.


  It looks like we've generally achieved consensus on the visual changes. Could folks \
review  D15194 <https://phabricator.kde.org/D15194> and D15206 \
<https://phabricator.kde.org/D15206>? As for the focus ring, I could use a hand with \
this. I tried editing the SVG to reduce the size of the active focus ring by removing \
the outer lighter line that increases its size, but the changed SVG was just sized \
back up to the original dimensions and looked even stronger. Am I missing something?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: acrouthamel, fabianr, huftis, rooty, sharvey, romangg, broulik, safaalfulaij, \
oysteins, filipf, abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15011">View Revision</a></tr></table><br \
/><div><div><p>It looks like we&#039;ve generally achieved consensus on the visual \
changes. Could folks review  <a href="https://phabricator.kde.org/D15194" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D15194</a> and <a \
href="https://phabricator.kde.org/D15206" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D15206</a>? As for the focus ring, I \
could use a hand with this. I tried editing the SVG to reduce the size of the active \
focus ring by removing the outer lighter line that increases its size, but the \
changed SVG was just sized back up to the original dimensions and looked even \
stronger. Am I missing something?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15011">https://phabricator.kde.org/D15011</a></div></div><br \
/><div><strong>To: </strong>ngraham, Plasma, VDG, davidedmundson, abetts<br \
/><strong>Cc: </strong>acrouthamel, fabianr, huftis, rooty, sharvey, romangg, \
broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, michaeltunnell, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]