[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15187: Merge switch user dialog into lockscreen
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-08-31 19:38:10
Message-ID: 2dc70edc5e268e986c052c3571988888 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham added a comment.


  Doesn't build for me:
  
    make[2]: *** No rule to make target \
'/usr/share/dbus-1/interfaces/org.kde.screensaver.xml', needed by \
'ksmserver/kscreenlocker_interface.cpp'.  Stop.  CMakeFiles/Makefile2:3454: recipe \
for target 'ksmserver/CMakeFiles/kdeinit_ksmserver.dir/all' failed  make[1]: *** \
[ksmserver/CMakeFiles/kdeinit_ksmserver.dir/all] Error 2  make[1]: *** Waiting for \
unfinished jobs....  [ 37%] Built target krunner
    Makefile:127: recipe for target 'all' failed
    make: *** [all] Error 2
  
  +1 on the idea though; the switch user screen has always been a bit unnerving for \
various reasons. I think this will be much nicer.  
  That said, I can foresee one potential issue: the interactive parts of the \
lockscreen UI aren't shown by default; you need to wiggle the mouse or bang on the \
keyboard to get anything interactive to show up. When we've entered the lockscreen in \
user switcher mode, I think the UI should be visible by default, since immediate user \
interaction is expected.  
  (if it already it, please ignore this part of the comment; I couldn't test it out \
because of the aforementioned compile error)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15187

To: davidedmundson, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15187">View Revision</a></tr></table><br \
/><div><div><p>Doesn&#039;t build for me:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">make[2]: *** No rule to make \
target &#039;/usr/share/dbus-1/interfaces/org.kde.screensaver.xml&#039;, needed by \
&#039;ksmserver/kscreenlocker_interface.cpp&#039;.  Stop. CMakeFiles/Makefile2:3454: \
recipe for target &#039;ksmserver/CMakeFiles/kdeinit_ksmserver.dir/all&#039; failed \
make[1]: *** [ksmserver/CMakeFiles/kdeinit_ksmserver.dir/all] Error 2 make[1]: *** \
Waiting for unfinished jobs.... [ 37%] Built target krunner
Makefile:127: recipe for target &#039;all&#039; failed
make: *** [all] Error 2</pre></div>

<p>+1 on the idea though; the switch user screen has always been a bit unnerving for \
various reasons. I think this will be much nicer.</p>

<p>That said, I can foresee one potential issue: the interactive parts of the \
lockscreen UI aren&#039;t shown by default; you need to wiggle the mouse or bang on \
the keyboard to get anything interactive to show up. When we&#039;ve entered the \
lockscreen in user switcher mode, I think the UI should be visible by default, since \
immediate user interaction is expected.</p>

<p>(if it already it, please ignore this part of the comment; I couldn&#039;t test it \
out because of the aforementioned compile error)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15187">https://phabricator.kde.org/D15187</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, mart<br /><strong>Cc: \
</strong>ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]