[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D15187: Merge switch user dialog into lockscreen
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-08-31 13:41:12
Message-ID: 387c5b0c4c30fde0a1ee44643fc82493 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This reduces a bunch of code, both hidden in the backend as well as the
mostly duplicated front end UI, making it more consistent for users too.
There is a behavioural change that switching user then cancelling will
require your own password. I would argue this is a good thing.
KSMServer still has the same DBus slot for compatibility which then
proxies over to the screensaver. This could be calling itself, it might
be calling kwin when we're on wayland.
TEST PLAN
Pressed switch user from the UI
Got a swich user dialog
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15187
AFFECTED FILES
ksmserver/CMakeLists.txt
ksmserver/server.cpp
ksmserver/switchuser-greeter/CMakeLists.txt
ksmserver/switchuser-greeter/main.cpp
lookandfeel/contents/userswitcher/UserSwitcher.qml
To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a \
subscriber: plasma-devel.<br />davidedmundson requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15187">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>This reduces a bunch of code, both \
hidden in the backend as well as the<br /> mostly duplicated front end UI, making it \
more consistent for users too.</p>
<p>There is a behavioural change that switching user then cancelling will<br />
require your own password. I would argue this is a good thing.</p>
<p>KSMServer still has the same DBus slot for compatibility which then<br />
proxies over to the screensaver. This could be calling itself, it might<br />
be calling kwin when we're on wayland.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Pressed switch user from the UI<br /> Got a swich user \
dialog</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15187">https://phabricator.kde.org/D15187</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>ksmserver/CMakeLists.txt<br /> \
ksmserver/server.cpp<br /> ksmserver/switchuser-greeter/CMakeLists.txt<br />
ksmserver/switchuser-greeter/main.cpp<br />
lookandfeel/contents/userswitcher/UserSwitcher.qml</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic