[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15185: Fix kscreenlocker_greet --switchuser
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-08-31 13:14:53
Message-ID: 9873a9205560823f5e86116800c86a09 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Years ago support was added for the lockscreen to default into switch user
  mode. The goal being to simplify one more task from ksmserver.
  
  It got postponed because it clashed with a change Kai made at the time.
  Now I'm restoring that.
  
  The code broke in the lockscreen rewrite.

TEST PLAN
  Called the switchUser DBus method
  Lockscreen spawned on the right page
  Locked screen normally, got the normal page

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15185

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a \
subscriber: plasma-devel.<br />davidedmundson requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15185">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Years ago support was added for the \
lockscreen to default into switch user<br /> mode. The goal being to simplify one \
more task from ksmserver.</p>

<p>It got postponed because it clashed with a change Kai made at the time.<br />
Now I&#039;m restoring that.</p>

<p>The code broke in the lockscreen rewrite.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Called the switchUser DBus method<br /> Lockscreen spawned on \
the right page<br /> Locked screen normally, got the normal page</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15185">https://phabricator.kde.org/D15185</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>lookandfeel/contents/lockscreen/LockScreenUi.qml</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]