[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-08-30 23:17:43
Message-ID: 12fb5ab38a8e9565493e545a2497ba5b () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson added a comment.


  Other than the one comment it's good to go.
  
  Though my stuff requires a frameworks feature and I haven't got my stuff is done in \
time for 5.14, sorry !  It can be the first 5.15 feature.

INLINE COMMENTS

> wallpaperplugin.h:42-43
> +
> +    Q_SIGNALS:
> +        void wallpaperPluginListChanged();
> +

We can get rid of this and the slot that emits this.

I made the wallpaper plugin model update magically.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12040">View Revision</a></tr></table><br \
/><div><div><p>Other than the one comment it&#039;s good to go.</p>

<p>Though my stuff requires a frameworks feature and I haven&#039;t got my stuff is \
done in time for 5.14, sorry !<br /> It can be the first 5.15 \
feature.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D12040#inline-81333">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">wallpaperplugin.h:42-43</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#a0a000">Q_SIGNALS</span><span class="p">:</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">void</span> <span class="n">wallpaperPluginListChanged</span><span \
class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We \
can get rid of this and the slot that emits this.</p>

<p style="padding: 0; margin: 8px;">I made the wallpaper plugin model update \
magically.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12040">https://phabricator.kde.org/D12040</a></div></div><br \
/><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>ngraham, cfeck, \
mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]