[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15170: Add icon names for root level kicker, recent docs, recent apps, power and: session
From:       Marcus Bonhagen <noreply () phabricator ! kde ! org>
Date:       2018-08-30 13:13:20
Message-ID: 5c5a497be141501fc686c364c2da6532 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

marcusb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
marcusb requested review of this revision.

REVISION SUMMARY
  The boolean "showIconsRootLevel" made it possible to show category icons on the root level of \
the kicker startmenu.   Because of that the categories have icons but the menu entries for \
recent documents, recent applications and power and session are left without icon.  This fix \
makes it possible to set icon names for the three missing icons.

TEST PLAN
  1. set the "showIconsRootLevel" of true in applets/kicker/package/contents/config/main.xml
  2. make sure this has an effect. -> category icons are in front of the entries
  3. see that there are icons missing for recent documents, recent applications and power / \
session .  4. set the icons introduced by this fix
  5. make sure the change has an effect
  6. icons are present

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15170

AFFECTED FILES
  applets/kicker/package/contents/config/main.xml
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h

To: marcusb
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">marcusb created this revision.<br />Herald added a project: Plasma.<br \
/>Herald added a subscriber: plasma-devel.<br />marcusb requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: \
#464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15170">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The boolean \
&quot;showIconsRootLevel&quot; made it possible to show category icons on the root level of the \
kicker startmenu. <br /> Because of that the categories have icons but the menu entries for \
recent documents, recent applications and power and session are left without icon.<br /> This \
fix makes it possible to set icon names for the three missing icons.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><ol class="remarkup-list"> <li \
class="remarkup-list-item">set the &quot;showIconsRootLevel&quot; of true in \
applets/kicker/package/contents/config/main.xml</li> <li class="remarkup-list-item">make sure \
this has an effect. -&gt; category icons are in front of the entries</li> <li \
class="remarkup-list-item">see that there are icons missing for recent documents, recent \
applications and power / session .</li> <li class="remarkup-list-item">set the icons introduced \
by this fix</li> <li class="remarkup-list-item">make sure the change has an effect</li>
<li class="remarkup-list-item">icons are present</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15170">https://phabricator.kde.org/D15170</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/kicker/package/contents/config/main.xml<br /> \
applets/kicker/package/contents/ui/main.qml<br /> applets/kicker/plugin/rootmodel.cpp<br />
applets/kicker/plugin/rootmodel.h</div></div></div><br /><div><strong>To: </strong>marcusb<br \
/><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]