[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15162: [Folder View] Disable the actions themselves rather than just not adding them to the menu
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-08-30 9:52:22
Message-ID: 039349acb13a91ab272b06781c201b37 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik updated this revision to Diff 40687.
broulik edited the test plan for this revision.
broulik added a comment.


  - Also check for `rename` action when pressing F2

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15162?vs=40685&id=40687

REVISION DETAIL
  https://phabricator.kde.org/D15162

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, davidedmundson, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik updated this revision to Diff 40687.<br />broulik \
edited the test plan for this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-hkq7qp5k3iqgxou/">(Show \
Details)</a><br />broulik added a comment. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15162">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Also check for \
<tt style="background: #ebebeb; font-size: 13px;">rename</tt> action when pressing \
F2</li> </ul></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div \
style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px \
0;">...</div>* Some options that make no sense for trash (Rename, &quot;Create \
New&quot;) are hidden, like in Dolphin<br /> <span style="padding: 0 2px; color: \
#333333; background: rgba(251, 175, 175, .7);">* F2 still unconditionally allows \
renam</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, \
151, .6);">* Pressing Delete, F2, Ctrl+X, etc do noth</span>ing <span style="padding: \
0 2px; color: #333333; background: rgba(251, 175, 175, .7);">but that is because QML \
doesn&#039;t check</span><span style="padding: 0 2px; color: #333333; background: \
rgba(151, 234, 151, .6);">when the actions are disabled</span><br /> <br />
Together with D15160 this allows locking down the desktop for the user when you make \
the desktop folder read-only</div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D15162?vs=40685&amp;id=40687">https://phabricator.kde.org/D15162?vs=40685&amp;id=40687</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15162">https://phabricator.kde.org/D15162</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/package/contents/ui/FolderView.qml<br /> \
containments/desktop/plugins/folder/foldermodel.cpp</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson, hein<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]