[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D15143: Allow creation of separator Actions
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-08-29 12:36:26
Message-ID: c1a8dfc0319874e0de4743f5a3a1caac () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
broulik added inline comments.
INLINE COMMENTS
> Action.qml:172
> + */
> + function isSeparator() {
> + return separator;
That function is superfluous, you have the property after all
> ActionsMenu.qml:55
> if (!action.children || action.children.length === 0) {
> - item = theMenu.itemDelegate.createObject(null, { ourAction: action });
> + if (typeof action.isSeparator === "function" && action.isSeparator()) {
> + item = theMenu.separatorDelegate.createObject(null, {});
`if (action.separator)`?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D15143
To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15143">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15143#inline-81153">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Action.qml:172</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #74777d"> */</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">function</span> <span style="color: #004012">isSeparator</span><span \
class="p">()</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">return</span> <span style="color: #004012">separator</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That \
function is superfluous, you have the property after all</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15143#inline-81154">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ActionsMenu.qml:55</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span \
style="color: #004012">action</span><span class="p">.</span><span style="color: \
#004012">children</span> <span style="color: #aa2211">||</span> <span style="color: \
#004012">action</span><span class="p">.</span><span style="color: \
#004012">children</span><span class="p">.</span><span style="color: \
#004012">length</span> <span style="color: #aa2211">===</span> <span style="color: \
#601200">0</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<span style="color: #004012">i<span class="bright">tem</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">=</span></span><span class="bright"> </span><span style="color: \
#004012"><span class="bright">theMenu</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">itemDelegate</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">createObject</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #000a65"><span class="bright">null</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">ourA</span>ction<span class="bright">:</span></span> <span \
style="color: #004012">action<span class="bright"></span></span><span class="bright"> \
</span><span class="p"><span class="bright">});</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">i<span class="bright">f</span></span><span \
class="bright"> </span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">typeof</span></span><span class="bright"> </span><span style="color: \
#004012"><span class="bright">action</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">isSeparator</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">===</span></span><span class="bright"> </span><span style="color: \
#766510"><span class="bright">"fun</span>ction<span \
class="bright">"</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">&&</span></span> <span style="color: \
#004012">action<span class="bright"></span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">isSeparator</span></span><span \
class="bright"></span><span class="p"><span class="bright">())</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #004012">item</span> <span \
style="color: #aa2211">=</span> <span style="color: #004012">theMenu</span><span \
class="p">.</span><span style="color: #004012">separatorDelegate</span><span \
class="p">.</span><span style="color: #004012">createObject</span><span \
class="p">(</span><span style="color: #000a65">null</span><span class="p">,</span> \
<span class="p">{});</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: 13px;">if \
(action.separator)</tt>?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15143">https://phabricator.kde.org/D15143</a></div></div><br \
/><div><strong>To: </strong>dkardarakos, mart<br /><strong>Cc: </strong>broulik, \
plasma-devel, apol, davidedmundson, mart, hein<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic