[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14695: disable title for QML kcms
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-08-28 14:13:11
Message-ID: 2a33b09a36f3f5a5d7a0ee7e2eaf6eab () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:309
> +        if (module && module->realModule()->inherits("KCModuleQml")) {
> +            page->setHeaderVisible(false);
> +        }

We can fix kcmmultidialog.cpp (addModule) where we have the page and the module \
object without doing weird hacks

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D14695

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added inline comments.<br />This revision now requires changes to \
proceed. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14695">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14695#inline-80994">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.cpp:309</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">module</span> <span style="color: #aa2211">&amp;&amp;</span> <span \
class="n">module</span><span style="color: #aa2211">-&gt;</span><span \
class="n">realModule</span><span class="p">()</span><span style="color: \
#aa2211">-&gt;</span><span class="n">inherits</span><span class="p">(</span><span \
style="color: #766510">&quot;KCModuleQml&quot;</span><span class="p">))</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">            <span class="n">page</span><span style="color: \
#aa2211">-&gt;</span><span class="n">setHeaderVisible</span><span \
class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We \
can fix kcmmultidialog.cpp (addModule) where we have the page and the module object \
without doing weird hacks</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R126 KDE CLI \
Utilities</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14695">https://phabricator.kde.org/D14695</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]