[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15026: Fetch high-resolution image from Bing
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-08-28 9:35:31
Message-ID: 941c3b7ebba91c768087fecd23d78d75 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't see how you can be sure that the 1920_1080 resolution version of the image \
exists,  
  It seems more that we need to patch the request *in* to bing to get a correct Url \
back.  
  -----
  
  Please test patches first. If you need help compiling plasma, please ask.

INLINE COMMENTS

> bingprovider.cpp:71
> }
> +        auto url = urlbase + "_1920x1080.jpg";
> QUrl picUrl(QStringLiteral("https://www.bing.com/%1").arg(url.toString()));

I don't see how this would compile.

urlBase is a QVariant, you can't append to it.
You need to turn it to a string (the .toString below) here.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15026

To: carmenbianca, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added a comment.<br />This revision now requires changes to proceed. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15026">View Revision</a></tr></table><br \
/><div><div><p>I don&#039;t see how you can be sure that the 1920_1080 resolution \
version of the image exists,</p>

<p>It seems more that we need to patch the request *in* to bing to get a correct Url \
back.</p>

<hr class="remarkup-hr" />

<p>Please test patches first. If you need help compiling plasma, please \
ask.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D15026#inline-80923">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">bingprovider.cpp:71</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">        <span class="p">}</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">auto</span> <span class="n">url</span> <span style="color: #aa2211">=</span> \
<span class="n">urlbase</span> <span style="color: #aa2211">+</span> <span \
style="color: #766510">&quot;_1920x1080.jpg&quot;</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span \
class="n">QUrl</span> <span style="color: #004012">picUrl</span><span \
class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">&quot;https://www.bing.com/%1&quot;</span><span \
class="p">).</span><span class="n">arg</span><span class="p">(</span><span \
class="n">url</span><span class="p">.</span><span class="n">toString</span><span \
class="p">()));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
don&#039;t see how this would compile.</p>

<p style="padding: 0; margin: 8px;">urlBase is a QVariant, you can&#039;t append to \
it.<br /> You need to turn it to a string (the .toString below) \
here.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15026">https://phabricator.kde.org/D15026</a></div></div><br \
/><div><strong>To: </strong>carmenbianca, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]