[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14389: Invert shade button by same logic as keep-above button
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-08-27 21:06:26
Message-ID: de487640a487ba618a22fdb187606542 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham added a comment.


  In D14389#316227 <https://phabricator.kde.org/D14389#316227>, @hpereiradacosta \
wrote:  
  > IMHO: you should either
  >
  > - keep the same icon, use the invert-color to set active state (meaning: remove \
the "unshade" icon  > - keep to different icons, and not invert-color (in which case \
the active state is driven by the drawn icon) but not both.  
  
  Yeah, that was my initial concern here too, but when @andykluger tried #2, I didn't \
like the result. Perhaps we should have tried #1 as well. The slight issue there is \
that the Shade button kind of looks similar to the Keep Below button if it doesn't \
change. I'd be fine with making the Shade button not change its appearance when \
toggled, but a clearer icon might help if we adopt that solution.  
  The icon is of lesser importance though. @andykluger, if you're still around, what \
do you think about submitting another patch to make the Shade button not change its \
icon when toggled?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14389

To: andykluger, #breeze, ngraham, #vdg
Cc: hpereiradacosta, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14389">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D14389#316227" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D14389#316227</a>, <a \
href="https://phabricator.kde.org/p/hpereiradacosta/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@hpereiradacosta</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>IMHO: you should either</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">keep the same icon, use the invert-color to set active \
state (meaning: remove the &quot;unshade&quot; icon</li> <li \
class="remarkup-list-item">keep to different icons, and not invert-color (in which \
case the active state is driven by the drawn icon) but not both.</li> </ul></div>
</blockquote>

<p>Yeah, that was my initial concern here too, but when <a \
href="https://phabricator.kde.org/p/andykluger/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@andykluger</a> tried #2, I didn&#039;t like the \
result. Perhaps we should have tried #1 as well. The slight issue there is that the \
<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade \
"><span class="phui-tag-core ">Shade</span></span></span> button kind of looks \
similar to the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey \
phui-tag-shade "><span class="phui-tag-core ">Keep Below</span></span></span> button \
if it doesn&#039;t change. I&#039;d be fine with making the <span><span \
class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span \
class="phui-tag-core ">Shade</span></span></span> button not change its appearance \
when toggled, but a clearer icon might help if we adopt that solution.</p>

<p>The icon is of lesser importance though. <a \
href="https://phabricator.kde.org/p/andykluger/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@andykluger</a>, if you&#039;re still around, what \
do you think about submitting another patch to make the <span><span \
class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span \
class="phui-tag-core ">Shade</span></span></span> button not change its icon when \
toggled?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 \
Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14389">https://phabricator.kde.org/D14389</a></div></div><br \
/><div><strong>To: </strong>andykluger, Breeze, ngraham, VDG<br /><strong>Cc: \
</strong>hpereiradacosta, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]