[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15093: Add WireGuard capability.
From:       Jan Grulich <noreply () phabricator ! kde ! org>
Date:       2018-08-27 10:41:43
Message-ID: 5c8d595831bc108f2d469f6e09f91d2d () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jgrulich added a comment.


  That's a big change/patch, I'll look more closely as soon as possible. One thing I \
see at first look is different coding style, can you please follow Qt coding style? \
I'm sure that many parts of plasma-nm are not using consistent coding style, but you \
should try to follow this one https://wiki.qt.io/Qt_Coding_Style.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">jgrulich added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15093">View Revision</a></tr></table><br \
/><div><div><p>That&#039;s a big change/patch, I&#039;ll look more closely as soon as \
possible. One thing I see at first look is different coding style, can you please \
follow Qt coding style? I&#039;m sure that many parts of plasma-nm are not using \
consistent coding style, but you should try to follow this one <a \
href="https://wiki.qt.io/Qt_Coding_Style" class="remarkup-link" target="_blank" \
rel="noreferrer">https://wiki.qt.io/Qt_Coding_Style</a>.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15093">https://phabricator.kde.org/D15093</a></div></div><br \
/><div><strong>To: </strong>andersonbruce, Plasma, jgrulich, pino<br /><strong>Cc: \
</strong>pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]