[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D15011: [Kickoff] Make the search field always look like a search field
From: Filip Fila <noreply () phabricator ! kde ! org>
Date: 2018-08-24 14:26:18
Message-ID: 059c4bf9266b37169b4b8f46c04f50c7 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
filipf added a comment.
In D15011#314744 <https://phabricator.kde.org/D15011#314744>, @ngraham wrote:
> Of your mockups, I like the last one the best, but nonetheless I'm just not a fan \
of defining a custom textfield style here; I think we should follow the HIG. If we \
had a dedicated "search field" control that was more subtle than general textfields, \
we could use that, but we don't. Until and unless we create one, I think we should \
err on the side of internal consistency and use the pre-existing textfield control. \
> > I too am bothered by the amount of horizontal wasted space, which is one of the \
> > reasons why I proposed T9041: New "Home" tab for Kickoff \
> > <https://phabricator.kde.org/T9041>. But that's a discussion for another phab \
> > task :)
Agreed, consistency all across the UI is preferable to bursts of design ideas in \
particular places. After the proposal by Safa it occurred to me that maybe we \
overlooked adding an icon so the minimal change I see that can be done is to add a \
search icon to the left of "Type to search..." and remove the code that shows the \
"uname -a" information. Small improvement I'd say, but I don't know if it's enough. \
If not and if we can't modify the search box style too much, then functionality \
reasons triumph and the search box as is has to be shipped, but with still keeping in \
mind the future tasks of perhaps updating the HIG and/or redesigning Kickoff to not \
be as unibody.
And yep, saw that task, that's what I was referencing! Don't get me wrong, the \
Favorites tab is great at what it does, but a Home tab as a default tab would be an \
improvement.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D15011
To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts, \
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15011">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D15011#314744" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D15011#314744</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Of your mockups, I like the last one the \
best, but nonetheless I'm just not a fan of defining a custom textfield style \
here; I think we should follow the HIG. If we had a dedicated "search \
field" control that was more subtle than general textfields, we could use that, \
but we don't. Until and unless we create one, I think we should err on the side \
of internal consistency and use the pre-existing textfield control.</p>
<p>I too am bothered by the amount of horizontal wasted space, which is one of the \
reasons why I proposed <a href="https://phabricator.kde.org/T9041" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T9041: New "Home" tab for \
Kickoff</a>. But that's a discussion for another phab task :)</p></div> \
</blockquote>
<p>Agreed, consistency all across the UI is preferable to bursts of design ideas in \
particular places. After the proposal by Safa it occurred to me that maybe we \
overlooked adding an icon so the minimal change I see that can be done is to add a \
search icon to the left of "Type to search..." and remove the code that \
shows the "uname -a" information. Small improvement I'd say, but I \
don't know if it's enough. If not and if we can't modify the search \
box style too much, then functionality reasons triumph and the search box as is has \
to be shipped, but with still keeping in mind the future tasks of perhaps updating \
the HIG and/or redesigning Kickoff to not be as unibody.</p>
<p>And yep, saw that task, that's what I was referencing! Don't get me \
wrong, the Favorites tab is great at what it does, but a Home tab as a default tab \
would be an improvement.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15011">https://phabricator.kde.org/D15011</a></div></div><br \
/><div><strong>To: </strong>ngraham, Plasma, VDG, davidedmundson, abetts<br \
/><strong>Cc: </strong>rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, \
filipf, abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic