[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14949: Add option for whether to show the volume change OSD
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-08-20 13:27:13
Message-ID: 9b03d0a1148eb8cdaaae7ed4cbbeb114 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added inline comments.

INLINE COMMENTS

> main.xml:15
> </entry>
> -    <entry name="volumeFeedback" type="Bool">
> +    <entry name="volumeAudioFeedback" type="Bool">
> +      <default>true</default>

You cannot rename that existing key as it would reset every user to the default value \
then as it would read from a new key

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14949">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14949#inline-79676">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.xml:15</span></div> <div style="font: \
11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: \
0 8px; margin: 0 4px; ">    <span style="color: #00702a">&lt;/entry&gt;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">    <span style="color: #00702a">&lt;entry</span> <span style="color: \
#354bb3">name=</span><span style="color: #766510">&quot;volumeFeedback&quot;</span> \
<span style="color: #354bb3">type=</span><span style="color: \
#766510">&quot;Bool&quot;</span><span style="color: #00702a">&gt;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #00702a">&lt;entry</span> <span style="color: \
#354bb3">name=</span><span style="color: #766510">&quot;volume<span \
class="bright">Audio</span>Feedback&quot;</span> <span style="color: \
#354bb3">type=</span><span style="color: #766510">&quot;Bool&quot;</span><span \
style="color: #00702a">&gt;</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">      <span style="color: \
#00702a">&lt;default&gt;</span>true<span style="color: \
#00702a">&lt;/default&gt;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
cannot rename that existing key as it would reset every user to the default value \
then as it would read from a new key</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14949">https://phabricator.kde.org/D14949</a></div></div><br \
/><div><strong>To: </strong>anonym<br /><strong>Cc: </strong>broulik, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]