[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14807: [AppStream Runner] Also search when there were errors during Pool::load
From:       Stefan_Brüns <noreply () phabricator ! kde ! org>
Date:       2018-08-15 13:17:10
Message-ID: fec92b4e8fde806fd8f0d473d031f108 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

bruns added a comment.


  In D14807#309460 <https://phabricator.kde.org/D14807#309460>, @apol wrote:
  
  > This is outright weird, please send just one patch with the feature and the \
logging and without the wrong lines.  
  
  Which wrong lines?
  
  Why should I squash the commits? Each one:
  
  - compiles **and** works on its own
  - addresses a slightly different issue

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, mart


[Attachment #3 (text/html)]

<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14807">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D14807#309460" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D14807#309460</a>, <a \
href="https://phabricator.kde.org/p/apol/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@apol</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>This is outright weird, please send just one \
patch with the feature and the logging and without the wrong lines.</p></div> \
</blockquote>

<p>Which wrong lines?</p>

<p>Why should I squash the commits? Each one:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">compiles <strong>and</strong> works on its own</li>
<li class="remarkup-list-item">addresses a slightly different issue</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14807">https://phabricator.kde.org/D14807</a></div></div><br \
/><div><strong>To: </strong>bruns, Plasma, apol<br /><strong>Cc: </strong>apol, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]