[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7087: Add "Copy Info" button to the About System KCM
From: Dominik Haumann <noreply () phabricator ! kde ! org>
Date: 2018-08-14 20:10:01
Message-ID: e0380a6963322def57cc22f549f6ebcd () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Ok from my side, although it still *feels* a bit messy :-)
- please consider using QVector before committing
- possibly fix the "Distro" thing, if applicable
INLINE COMMENTS
> Module.cpp:162
>
> + const auto dummyDistroDescriptionLabel = new QLabel(i18nc("@title:row", \
> "Distro:"), this); + dummyDistroDescriptionLabel->hide();
Is "Distro" a proper English term? Should it meaybe read "Distribution"?
> Module.h:73
> +
> + QList<QPair<QLabel*, QLabel*> > labelsForClipboard;
> +
For future: Please pretty much always prefer QVector over QList.
REPOSITORY
R102 KInfoCenter
BRANCH
arcpatch-D7087_1
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">dhaumann accepted this revision.<br />dhaumann added a \
comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7087">View \
Revision</a></tr></table><br /><div><div><p>Ok from my side, although it still \
*feels* a bit messy :-)</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">please consider using QVector before committing</li>
<li class="remarkup-list-item">possibly fix the "Distro" thing, if \
applicable</li> </ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-78703">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">Module.cpp:162</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> \
<span style="color: #aa4000">auto</span> <span \
class="n">dummyDistroDescriptionLabel</span> <span style="color: #aa2211">=</span> \
<span style="color: #aa4000">new</span> <span class="n">QLabel</span><span \
class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span \
style="color: #766510">"@title:row"</span><span class="p">,</span> <span \
style="color: #766510">"Distro:"</span><span class="p">),</span> <span \
style="color: #aa4000">this</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">dummyDistroDescriptionLabel</span><span style="color: \
#aa2211">-></span><span class="n">hide</span><span class="p">();</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Is "Distro" a proper English term? Should it meaybe read \
"Distribution"?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-78702">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Module.h:73</span></div> <div style="font: \
11px/15px "Menlo", "Consolas", "Monaco", monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">QList</span><span style="color: #aa2211"><</span><span \
class="n">QPair</span><span style="color: #aa2211"><</span><span \
class="n">QLabel</span><span style="color: #aa2211">*</span><span class="p">,</span> \
<span class="n">QLabel</span><span style="color: #aa2211">*></span> <span \
style="color: #aa2211">></span> <span class="n">labelsForClipboard</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For \
future: Please pretty much always prefer QVector over \
QList.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>arcpatch-D7087_1</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann, rkflx<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic