[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-08-14 14:13:07
Message-ID: c56fad95735c3bb4fcd9783f12c82b1d () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added inline comments.

INLINE COMMENTS

> networkmodel.cpp:220
> +    auto deviceStatistics = device->deviceStatistics();
> +    deviceStatistics->setRefreshRateMs(2000);
> +    connect(deviceStatistics.data(), \
> &NetworkManager::DeviceStatistics::rxBytesChanged, this, [this, device](qulonglong \
> rxBytes) {

Would it be better to only request the data when the statistics are open to avoid \
wakeups and processing?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14835

To: volkov, #plasma, jgrulich
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14835">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14835#inline-78601">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">networkmodel.cpp:220</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #aa4000">auto</span> <span class="n">deviceStatistics</span> <span \
style="color: #aa2211">=</span> <span class="n">device</span><span style="color: \
#aa2211">-&gt;</span><span class="n">deviceStatistics</span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">deviceStatistics</span><span \
style="color: #aa2211">-&gt;</span><span class="n">setRefreshRateMs</span><span \
class="p">(</span><span style="color: #601200">2000</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="n">connect</span><span class="p">(</span><span \
class="n">deviceStatistics</span><span class="p">.</span><span \
class="n">data</span><span class="p">(),</span> <span style="color: \
#aa2211">&amp;</span><span class="n">NetworkManager</span><span style="color: \
#aa2211">::</span><span class="n">DeviceStatistics</span><span style="color: \
#aa2211">::</span><span class="n">rxBytesChanged</span><span class="p">,</span> <span \
style="color: #aa4000">this</span><span class="p">,</span> <span \
class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> \
<span class="n">device</span><span class="p">](</span><span \
class="n">qulonglong</span> <span class="n">rxBytes</span><span class="p">)</span> \
<span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Would it be better to only request the data when the statistics are open to \
avoid wakeups and processing?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14835">https://phabricator.kde.org/D14835</a></div></div><br \
/><div><strong>To: </strong>volkov, Plasma, jgrulich<br /><strong>Cc: \
</strong>broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]