[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14647: Resolve relative service entry paths
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-08-06 12:29:49
Message-ID: c5789943ec9cdbf94bbd580a254cb830 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik created this revision.
broulik added reviewers: Plasma, dfaure, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For KCMs we get a relative `entryPath()` for our `KService` resulting in an invalid \
URL being created.  
  BUG: 397070

TEST PLAN
  5.12? The `QUrl` returned from that could be invalid now (empty), not sure if that \
could cause any problems elsewhere?  
  - Searched for "Colors", got Color KCM, successfully added it to favorites, to TM \
and panel (icon widget).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14647

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: broulik, #plasma, dfaure, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, dfaure, hein.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />broulik requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14647">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>For KCMs we get a relative <tt \
style="background: #ebebeb; font-size: 13px;">entryPath()</tt> for our <tt \
style="background: #ebebeb; font-size: 13px;">KService</tt> resulting in an invalid \
URL being created.</p>

<p>BUG: 397070</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>5.12? The \
<tt style="background: #ebebeb; font-size: 13px;">QUrl</tt> returned from that could \
be invalid now (empty), not sure if that could cause any problems elsewhere?</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Searched for &quot;Colors&quot;, got Color KCM, \
successfully added it to favorites, to TM and panel (icon widget).</li> \
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14647">https://phabricator.kde.org/D14647</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/kicker/plugin/actionlist.cpp<br /> \
applets/kicker/plugin/actionlist.h<br /> applets/kicker/plugin/appentry.cpp<br />
applets/kicker/plugin/runnermatchesmodel.cpp</div></div></div><br /><div><strong>To: \
</strong>broulik, Plasma, dfaure, hein<br /><strong>Cc: </strong>plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]