[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14542: WIP: Basic KCM using new virtual desktops DBus interface
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-08-02 10:00:58
Message-ID: b5dd039c2f66993b9be93837899e30f5 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
broulik added a comment.
That DBus stuff looks like it was painful to write :/
It seems the KCM does auto-apply of everything (desktop names, adding, removing \
them) which is not what we usually do, and neither did the old KCM
INLINE COMMENTS
> desktopsmodel.cpp:92
> + QStringLiteral("org.kde.KWin.VirtualDesktopManager"),
> + QStringLiteral("rowsChanged"),
> + this,
Architectural question: why don't you go the standard \
`org.freedesktop.DBus.Properties.PropertiesChanged` way?
> desktopsmodel.cpp:105
> + QStringLiteral("/VirtualDesktopManager"),
> + QStringLiteral("org.freedesktop.DBus.Properties"),
> + QStringLiteral("Get"));
Can you put a couple of static `QString`s somewhere to avoid copy-pasting this all \
over?
> desktopsmodel.cpp:165
> +
> + const int perRow = std::ceil((qreal)m_desktops.count() / (qreal)m_rows);
> + return (index.row() / perRow) + 1;
`m_rows` can potentially be `0` here
> main.qml:160
> +
> + QtControls.Button {
> + Layout.alignment: Qt.AlignRight
Add `list-add` icon
> virtualdesktops.cpp:40
> + i18n("Configure Virtual Desktops"),
> + QStringLiteral("2.0"), QString(), KAboutLicense::GPL);
> + setAboutData(about);
Copyright headers in the code say LGPL
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D14542
To: hein, mart
Cc: broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, \
bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, \
apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14542">View Revision</a></tr></table><br \
/><div><div><p>That DBus stuff looks like it was painful to write :/</p>
<p>It seems the KCM does auto-apply of everything (desktop names, adding, removing \
them) which is not what we usually do, and neither did the old KCM</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14542#inline-76828">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktopsmodel.cpp:92</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"org.kde.KWin.VirtualDesktopManager"</span><span \
class="p">),</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span \
class="p">(</span><span style="color: #766510">"rowsChanged"</span><span \
class="p">),</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">this</span><span \
class="p">,</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Architectural question: why don't you go the standard <tt \
style="background: #ebebeb; font-size: \
13px;">org.freedesktop.DBus.Properties.PropertiesChanged</tt> way?</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14542#inline-76829">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktopsmodel.cpp:105</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"/VirtualDesktopManager"</span><span class="p">),</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">"org.freedesktop.DBus.Properties"</span><span \
class="p">),</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span \
class="p">(</span><span style="color: #766510">"Get"</span><span \
class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can \
you put a couple of static <tt style="background: #ebebeb; font-size: \
13px;">QString</tt>s somewhere to avoid copy-pasting this all \
over?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14542#inline-76831">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">desktopsmodel.cpp:165</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">const</span> <span style="color: #aa4000">int</span> <span \
class="n">perRow</span> <span style="color: #aa2211">=</span> <span \
class="n">std</span><span style="color: #aa2211">::</span><span \
class="n">ceil</span><span class="p">((</span><span class="n">qreal</span><span \
class="p">)</span><span class="n">m_desktops</span><span class="p">.</span><span \
class="n">count</span><span class="p">()</span> <span style="color: #aa2211">/</span> \
<span class="p">(</span><span class="n">qreal</span><span class="p">)</span><span \
class="n">m_rows</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">return</span> <span class="p">(</span><span class="n">index</span><span \
class="p">.</span><span class="n">row</span><span class="p">()</span> <span \
style="color: #aa2211">/</span> <span class="n">perRow</span><span class="p">)</span> \
<span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: 13px;">m_rows</tt> can potentially be <tt \
style="background: #ebebeb; font-size: 13px;">0</tt> here</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14542#inline-76833">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:160</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #004012">QtControls</span><span class="p">.</span><span \
style="color: #004012">Button</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">Layout.alignment:</span> <span style="color: \
#004012">Qt</span><span class="p">.</span><span style="color: \
#004012">AlignRight</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Add \
<tt style="background: #ebebeb; font-size: 13px;">list-add</tt> \
icon</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14542#inline-76835">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">virtualdesktops.cpp:40</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">i18n</span><span class="p">(</span><span style="color: \
#766510">"Configure Virtual Desktops"</span><span class="p">),</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">"2.0"</span><span class="p">),</span> <span \
class="n">QString</span><span class="p">(),</span> <span \
class="n">KAboutLicense</span><span style="color: #aa2211">::</span><span \
class="n">GPL</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">setAboutData</span><span class="p">(</span><span \
class="n">about</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Copyright headers in the code say LGPL</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14542">https://phabricator.kde.org/D14542</a></div></div><br \
/><div><strong>To: </strong>hein, mart<br /><strong>Cc: </strong>broulik, \
plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic