[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14549: EDID parsing: replace non-printable characters with '-'
From:       Frederik Gladhorn <noreply () phabricator ! kde ! org>
Date:       2018-08-02 9:25:48
Message-ID: 6c06406058dd76f0e25aa3e8f09bfd04 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  Simplify first to not have zero terminators suddenly replaced by '-'.
  This makes some screen names a lot more readable since the encoding
  seems always problematic. According to the standard it should be ipm
  437, but even with that code page, many EDIDs seem to produce garbage.
  Local8Bit also doesn't make much sense, so use Latin1 as a good
  compromise and replace everything that's not in range.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14549

AFFECTED FILES
  autotests/testedid.cpp
  src/edid.cpp

To: gladhorn, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">gladhorn created this revision.<br />gladhorn added a \
reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />gladhorn requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14549">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Simplify first to not have zero \
terminators suddenly replaced by &#039;-&#039;.<br /> This makes some screen names a \
lot more readable since the encoding<br /> seems always problematic. According to the \
standard it should be ipm<br /> 437, but even with that code page, many EDIDs seem to \
produce garbage.<br /> Local8Bit also doesn&#039;t make much sense, so use Latin1 as \
a good<br /> compromise and replace everything that&#039;s not in \
range.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R110 KScreen \
Library</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14549">https://phabricator.kde.org/D14549</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>autotests/testedid.cpp<br /> \
src/edid.cpp</div></div></div><br /><div><strong>To: </strong>gladhorn, Plasma<br \
/><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]