[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14487: [Klipper] Only create KHelpMenu when used
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-07-31 10:23:32
Message-ID: 3d0806d34681d3742f0b09aa2d0761f5 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added a comment.


  > What issue did this cause?
  
  A bunch of useless `QActions`, `createActions` is called in `KHelpMenu` \
constructor. The menu itself is created lazily but the `QAction` instances are not

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14487

To: broulik, #plasma, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14487">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>What issue did this cause?</p></blockquote>

<p>A bunch of useless <tt style="background: #ebebeb; font-size: \
13px;">QActions</tt>, <tt style="background: #ebebeb; font-size: \
13px;">createActions</tt> is called in <tt style="background: #ebebeb; font-size: \
13px;">KHelpMenu</tt> constructor. The menu itself is created lazily but the <tt \
style="background: #ebebeb; font-size: 13px;">QAction</tt> instances are \
not</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14487">https://phabricator.kde.org/D14487</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, graesslin, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]