[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14493: fontinst quits after KJob is done
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2018-07-31 9:45:48
Message-ID: 65ce8bb27edc0f455ff48064f4377804 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dfaure added a comment.


  Ah so it's kind of a daemon, that should keep running until logout? I wasn't aware \
of that, I thought it was a KCM. Disabling as in the first patch made sense then ;)  
  Either version is fine with me.

INLINE COMMENTS

> FontInst.h:161
> +    // This is needed because KJob uses an event loop locker internally,
> +    // which causes fontinst to quit after the job is done.
> +    QEventLoopLocker loopLocker;

"which would otherwise cause fontinst...."

Don't describe the past as the present, for future readers of this code ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14493">View Revision</a></tr></table><br \
/><div><div><p>Ah so it&#039;s kind of a daemon, that should keep running until \
logout? I wasn&#039;t aware of that, I thought it was a KCM. Disabling as in the \
first patch made sense then ;)</p>

<p>Either version is fine with me.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14493#inline-76546">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">FontInst.h:161</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #74777d">// This is needed because KJob uses an event loop locker \
internally,</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span style="color: #74777d">// which causes fontinst \
to quit after the job is done.</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">QEventLoopLocker</span> <span class="n">loopLocker</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">&quot;which would otherwise cause fontinst....&quot;</p>

<p style="padding: 0; margin: 8px;">Don&#039;t describe the past as the present, for \
future readers of this code ;)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14493">https://phabricator.kde.org/D14493</a></div></div><br \
/><div><strong>To: </strong>mathiastillman, Plasma, dfaure, aacid, gateau<br \
/><strong>Cc: </strong>wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]