View Revision
apol added a comment.

Please, do some review yourself, you should be able to see most of these things yourself


INLINE COMMENTS
View InlineFwupdSourcesBackend.cpp:151
{
return m_actions ;
}

return {} and remove the unused attribute.


View InlineFwupdSourcesBackend.h:46
bool supportsAdding() const override { return false; }
void eulaRequired(const QString& remoteName , const QString& licenseAgreement);
void populateSources();

There's no space before a coma.


View InlineFwupdSourcesBackend.h:54
FwupdSourcesModel* m_sources;
QList<QAction*> m_actions;
};

Remove.


View InlineFwupdTransaction.cpp:99
QNetworkAccessManager *manager = new QNetworkAccessManager(this);
connect(manager, SIGNAL(finished(QNetworkReply*)),this, SLOT(fwupdInstall(QNetworkReply*)));
manager->get(QNetworkRequest(uri));

Use proper connect syntax.


View InlineFwupdTransaction.cpp:160
void FwupdTransaction::iterateTransaction()
{

Give it a name that says what it does, this is just copied from the dummy and thus it has a meaningless name.


REPOSITORY
R134 Discover Software Store

REVISION DETAIL
https://phabricator.kde.org/D14050

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart