Please, do some review yourself, you should be able to see most of these things yourself
INLINE COMMENTS
return {} and remove the unused attribute.
bool supportsAdding() const override { return false; }
void eulaRequired(const QString& remoteName , const QString& licenseAgreement);
void populateSources();
There's no space before a coma.
FwupdSourcesModel* m_sources;
QList<QAction*> m_actions;
};
QNetworkAccessManager *manager = new QNetworkAccessManager(this);
connect(manager, SIGNAL(finished(QNetworkReply*)),this, SLOT(fwupdInstall(QNetworkReply*)));
manager->get(QNetworkRequest(uri));
Use proper connect syntax.
void FwupdTransaction::iterateTransaction()
{
Give it a name that says what it does, this is just copied from the dummy and thus it has a meaningless name.
REPOSITORYR134 Discover Software Store
To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart