[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14444: Use nullptr/override
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-07-28 16:47:21
Message-ID: 6ab89b8917b17bb689e127aa8ac70604 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

zzag added inline comments.

INLINE COMMENTS

> ListViewSettings.cpp:47
> delete m_settingsWidget;
> +  m_settingsWidget = nullptr;
> }

This class is about to go away so this assignment is redundant.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D14444

To: al1xz
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14444">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14444#inline-76108">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ListViewSettings.cpp:47</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">delete</span> \
<span class="n">m_settingsWidget</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span \
class="n">m_settingsWidget</span> <span style="color: #aa2211">=</span> <span \
style="color: #aa4000">nullptr</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
class is about to go away so this assignment is \
redundant.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R106 KSysguard</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14444">https://phabricator.kde.org/D14444</a></div></div><br \
/><div><strong>To: </strong>al1xz<br /><strong>Cc: </strong>zzag, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]