[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14050: Fwupd Backend For Review and Improvement
From:       Abhijeet  sharma <noreply () phabricator ! kde ! org>
Date:       2018-07-25 16:06:12
Message-ID: 9f9d2567978b95106b625e2559ab7bc6 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

abhijeet2096 updated this revision to Diff 38440.
abhijeet2096 marked an inline comment as done.
abhijeet2096 added a comment.


  - Removed FindSoup.cmake,FindGObjectIntrospection.cmake
  - Removed FwupdTest
  - using nullptr instead of NULL
  - Now using file path instead of file
  - Now using QVector instead of QList for storing the reference of releases
  - Now using QString::fromUtf8 to convert to QString from gchar*
  - Tried New download for downloading firmware files during installation
  - Refactored SourceBackend code

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14050?vs=38183&id=38440

REVISION DETAIL
  https://phabricator.kde.org/D14050

AFFECTED FILES
  CMakeLists.txt
  cmake/FindGIO.cmake
  cmake/FindGLib.cmake
  cmake/FindGObject.cmake
  cmake/FindLIBFWUPD.cmake
  discover/qml/SourcesPage.qml
  libdiscover/backends/CMakeLists.txt
  libdiscover/backends/FwupdBackend/CMakeLists.txt
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdBackend.h
  libdiscover/backends/FwupdBackend/FwupdResource.cpp
  libdiscover/backends/FwupdBackend/FwupdResource.h
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.h
  libdiscover/backends/FwupdBackend/FwupdTransaction.cpp
  libdiscover/backends/FwupdBackend/FwupdTransaction.h
  libdiscover/resources/AbstractSourcesBackend.h

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">abhijeet2096 updated this revision to Diff 38440.<br \
/>abhijeet2096 marked an inline comment as done.<br />abhijeet2096 added a comment. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14050">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Removed \
FindSoup.cmake,FindGObjectIntrospection.cmake</li> <li \
class="remarkup-list-item">Removed FwupdTest</li> <li \
class="remarkup-list-item">using nullptr instead of NULL</li> <li \
class="remarkup-list-item">Now using file path instead of file</li> <li \
class="remarkup-list-item">Now using QVector instead of QList for storing the \
reference of releases</li> <li class="remarkup-list-item">Now using QString::fromUtf8 \
to convert to QString from gchar*</li> <li class="remarkup-list-item">Tried New \
download for downloading firmware files during installation</li> <li \
class="remarkup-list-item">Refactored SourceBackend code</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D14050?vs=38183&amp;id=38440">https://phabricator.kde.org/D14050?vs=38183&amp;id=38440</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14050">https://phabricator.kde.org/D14050</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
cmake/FindGIO.cmake<br /> cmake/FindGLib.cmake<br />
cmake/FindGObject.cmake<br />
cmake/FindLIBFWUPD.cmake<br />
discover/qml/SourcesPage.qml<br />
libdiscover/backends/CMakeLists.txt<br />
libdiscover/backends/FwupdBackend/CMakeLists.txt<br />
libdiscover/backends/FwupdBackend/FwupdBackend.cpp<br />
libdiscover/backends/FwupdBackend/FwupdBackend.h<br />
libdiscover/backends/FwupdBackend/FwupdResource.cpp<br />
libdiscover/backends/FwupdBackend/FwupdResource.h<br />
libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp<br />
libdiscover/backends/FwupdBackend/FwupdSourcesBackend.h<br />
libdiscover/backends/FwupdBackend/FwupdTransaction.cpp<br />
libdiscover/backends/FwupdBackend/FwupdTransaction.h<br />
libdiscover/resources/AbstractSourcesBackend.h</div></div></div><br \
/><div><strong>To: </strong>abhijeet2096, apol, davidedmundson<br /><strong>Cc: \
</strong>zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]