[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14362: Use unpretty channel name in speakertest
From:       Nicolas Fella <noreply () phabricator ! kde ! org>
Date:       2018-07-25 10:56:27
Message-ID: 044a3c48fc1f4bc0cce3e3055c91938c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

nicolasfella created this revision.
nicolasfella added reviewers: drosca, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The speaker test did not work when channel names were translated, e.g. "Front Left" \
=> "Vorne Links" because the comparison failed. Using pa_channel_position_to_string \
instead of pa_channel_position_to_pretty_string hopefully   works better.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  fixspeakertest

REVISION DETAIL
  https://phabricator.kde.org/D14362

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/sink.cpp
  src/sink.h
  src/volumeobject.cpp
  src/volumeobject.h

To: nicolasfella, drosca, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">nicolasfella created this revision.<br />nicolasfella added \
reviewers: drosca, broulik.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />nicolasfella \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14362">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>The speaker test did not work when \
channel names were translated, e.g. &quot;Front Left&quot; =&gt; &quot;Vorne \
Links&quot; because the comparison failed. Using pa_channel_position_to_string \
instead of pa_channel_position_to_pretty_string hopefully <br /> works \
better.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma \
Audio Volume Applet</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>fixspeakertest</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14362">https://phabricator.kde.org/D14362</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/kcm/package/contents/ui/Advanced.qml<br /> \
src/sink.cpp<br /> src/sink.h<br />
src/volumeobject.cpp<br />
src/volumeobject.h</div></div></div><br /><div><strong>To: </strong>nicolasfella, \
drosca, broulik<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]