[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14335: Make astronomical Plasma plugin JSON consistent with other plugins and translatable
From:       Yuri Chornoivan <noreply () phabricator ! kde ! org>
Date:       2018-07-24 14:45:32
Message-ID: 40d8daaa0a70b3444cc354af20bcdf8c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

yurchor created this revision.
yurchor added reviewers: Plasma, Localization.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Currently, JSON file has a structure which is not parsed by the scripty. The patch \
tries to fix this.

TEST PLAN
  1. Use of "python <some_dir>/createjsoncontext.py `find . -name \*.json` ./po" \
where <some_dir> is a clone of this dir: \
https://websvn.kde.org/trunk/l10n-kf5/scripts/ should extract messages from \
astronomicaleventsplugin.json (tested)  2. The plugin should work (not tested)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D14335

AFFECTED FILES
  plasmacalendarplugins/astronomical/astronomicaleventsplugin.json

To: yurchor, #plasma, #localization
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">yurchor created this revision.<br />yurchor added reviewers: \
Plasma, Localization.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />yurchor requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14335">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Currently, JSON file has a structure \
which is not parsed by the scripty. The patch tries to fix this.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><ol class="remarkup-list"> <li \
class="remarkup-list-item">Use of &quot;python &lt;some_dir&gt;/createjsoncontext.py \
<tt style="background: #ebebeb; font-size: 13px;">find . -name \*.json</tt> \
./po&quot; where &lt;some_dir&gt; is a clone of this dir: <a \
href="https://websvn.kde.org/trunk/l10n-kf5/scripts/" class="remarkup-link" \
target="_blank" rel="noreferrer">https://websvn.kde.org/trunk/l10n-kf5/scripts/</a> \
should extract messages from astronomicaleventsplugin.json (tested)</li> <li \
class="remarkup-list-item">The plugin should work (not tested)</li> \
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma \
Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14335">https://phabricator.kde.org/D14335</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>plasmacalendarplugins/astronomical/astronomicaleventsplugin.json</div></div></div><br \
/><div><strong>To: </strong>yurchor, Plasma, Localization<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]