[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D12498: Fully remove `Application Name` from Details panel
From: Stefan_Brüns <noreply () phabricator ! kde ! org>
Date: 2018-07-23 17:19:26
Message-ID: b85d0d8ffe8f87d5436cc65f9431cd57 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
bruns added a comment.
In D12498#296414 <https://phabricator.kde.org/D12498#296414>, @ngraham wrote:
> ... but I'd still prefer something a little bit more descriptive like "Not \
provided by <application>"
The problem is you can not really know the application. While often the Action-ID \
is derived from the upstream URL in reverse notation, in general it is independent \
from a specific implementation/application.
After removing the dreadful "Application: ..." line, the Details pane looks like \
this:
| Action | Eject media from a system drive |
| Action ID: | org.freedesktop.udisks2.eject-media-system |
| Vendor: | //The UDisks Project //<link to github> |
| polkit.subject-pid: | 6457 |
| polkit.caller-pid: | 6476 |
|
"Vendor" is optional according to the spec. So if we had a malformed rule file, it \
may read like this:
| Action | 'Description' not provided, please file a bug report |
| Action ID: | org.freedesktop.udisks2.eject-media-system |
| polkit.subject-pid: | 6457 |
| polkit.caller-pid: | 6476 |
|
REPOSITORY
R121 Policykit (Polkit) KDE Agent
REVISION DETAIL
https://phabricator.kde.org/D12498
To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D12498#296414" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12498#296414</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>... but I'd still prefer something a \
little bit more descriptive like "Not provided by \
<application>"</p></div> </blockquote>
<p>The problem is you can not really know the application. While often the Action-ID \
is derived from the upstream URL in reverse notation, in general it is independent \
from a specific implementation/application.</p>
<p>After removing the dreadful "Application: ..." line, the Details pane \
looks like this:</p>
<div class="remarkup-table-wrap"><table style="border-collapse: separate;
border-spacing: 1px;
background: #d3d3d3;
margin: 12px 0;">
<tr><td style="background: #ffffff;
padding: 3px 6px;">Action</td><td style="background: #ffffff;
padding: 3px 6px;">Eject media from a system drive</td></tr>
<tr><td style="background: #ffffff;
padding: 3px 6px;">Action ID:</td><td style="background: #ffffff;
padding: 3px 6px;">org.freedesktop.udisks2.eject-media-system</td></tr>
<tr><td style="background: #ffffff;
padding: 3px 6px;">Vendor:</td><td style="background: #ffffff;
padding: 3px 6px;"><em>The UDisks Project </em><link to \
github></td></tr> <tr><td style="background: #ffffff;
padding: 3px 6px;">polkit.subject-pid:</td><td style="background: #ffffff;
padding: 3px 6px;">6457</td></tr>
<tr><td style="background: #ffffff;
padding: 3px 6px;">polkit.caller-pid:</td><td style="background: #ffffff;
padding: 3px 6px;">6476</td></tr>
<tr></tr>
</table></div>
<p>"Vendor" is optional according to the spec. So if we had a malformed \
rule file, it may read like this:</p>
<div class="remarkup-table-wrap"><table style="border-collapse: separate;
border-spacing: 1px;
background: #d3d3d3;
margin: 12px 0;">
<tr><td style="background: #ffffff;
padding: 3px 6px;">Action</td><td style="background: #ffffff;
padding: 3px 6px;">'Description' not provided, please file a bug \
report</td></tr> <tr><td style="background: #ffffff;
padding: 3px 6px;">Action ID:</td><td style="background: #ffffff;
padding: 3px 6px;">org.freedesktop.udisks2.eject-media-system</td></tr>
<tr><td style="background: #ffffff;
padding: 3px 6px;">polkit.subject-pid:</td><td style="background: #ffffff;
padding: 3px 6px;">6457</td></tr>
<tr><td style="background: #ffffff;
padding: 3px 6px;">polkit.caller-pid:</td><td style="background: #ffffff;
padding: 3px 6px;">6476</td></tr>
<tr></tr>
</table></div>
</div></div><br /><div><strong>REPOSITORY</strong><div><div>R121 Policykit (Polkit) \
KDE Agent</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br \
/><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic