[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14147: Port from GConf to GSettings
From: David Rosca <noreply () phabricator ! kde ! org>
Date: 2018-07-17 6:45:49
Message-ID: aa4f9f51c5abf21d8f69bdc8eb87e531 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
drosca added inline comments.
INLINE COMMENTS
> CMakeLists.txt:46
> +
> +if(USE_GCONF AND USE_GSETTINGS)
> + message(FATAL_ERROR "USE_GCONF and USE_GSETTINGS cannot be used at the same \
> time")
This should probably use cache variables:
set(USE_GCONF FALSE CACHE STRING "Build with GConf")
set(USE_GSETTINGS TRUE CACHE STRING "Build with GSettings")
> gsettingsitem.cpp:22
> +#include <QVariant>
> +#include <QDebug>
> +
not needed
> gsettingsitem.cpp:26
> +
> +#include "gsettingsitem.h"
> +#include "debug.h"
local includes should be the first in file
> gsettingsitem.cpp:40
> + case G_VARIANT_CLASS_STRING:
> + toReturn = QVariant(QString::fromUtf8(g_variant_get_string(gvalue, \
> NULL))); + break;
nullptr
> gsettingsitem.cpp:53
> +{
> +
> + // It might be hard to detect the right GVariant type from
newline
> gsettingsitem.cpp:63
> + switch (g_variant_type_peek_string(g_variant_get_type(oldValue))[0]) {
> + case G_VARIANT_CLASS_BOOLEAN:
> + newValue = g_variant_new_boolean(val.toBool());
indentation
> gsettingsitem.cpp:73
> +
> + if (newValue)
> + g_settings_set_value(m_settings, key.toLatin1().data(), newValue);
braces
> gsettingsitem.cpp:82
> +{
> +
> + m_settings = g_settings_new_with_path("org.freedesktop.pulseaudio.module-group", \
> key.toLatin1().data());
newline
> gsettingsitem.cpp:91
> + g_settings_sync();
> + if (m_settings)
> + g_object_unref(m_settings);
braces
> gsettingsitem.h:34
> + public:
> +
> + explicit GSettingsItem(const QString &key, QObject *parent = nullptr);
newline
> gsettingsitem.h:41
> +
> +
> +Q_SIGNALS:
newline
> gsettingsitem.h:48
> +
> +static void settingChanged(GSettings *settings, const gchar *key, gpointer data)
> +{
move to .cpp
> modulemanager.cpp:93
> +#if USE_GCONF || USE_GSETTINGS
>
> + m_combineSinks = new ConfigModule(QStringLiteral("combine"), \
> QStringLiteral("module-combine"), this);
newline
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D14147
To: nicolasfella, drosca, davidedmundson
Cc: rikmills, broulik, asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">drosca added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14147">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74597">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:46</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">if(USE_GCONF AND USE_GSETTINGS) </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);"> message(FATAL_ERROR "USE_GCONF \
and USE_GSETTINGS cannot be used at the same time") </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
should probably use cache variables:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">set(USE_GCONF FALSE CACHE \
STRING "Build with GConf") set(USE_GSETTINGS TRUE CACHE STRING "Build \
with GSettings")</pre></div></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74587">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:22</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#include</span> <span class="cpf"><QVariant></span><span \
style="color: #304a96"></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> \
<span class="cpf"><QDebug></span><span style="color: #304a96"></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">not needed</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74585">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:26</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#include</span> <span \
class="cpf">"gsettingsitem.h"</span><span style="color: #304a96"></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #304a96">#include</span> <span \
class="cpf">"debug.h"</span><span style="color: #304a96"></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">local includes should be the first in file</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74586">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:40</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">case</span> <span style="color: \
#a0a000">G_VARIANT_CLASS_STRING</span><span class="p">:</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">toReturn</span> <span style="color: #aa2211">=</span> <span \
class="n">QVariant</span><span class="p">(</span><span class="n">QString</span><span \
style="color: #aa2211">::</span><span class="n">fromUtf8</span><span \
class="p">(</span><span class="n">g_variant_get_string</span><span \
class="p">(</span><span class="n">gvalue</span><span class="p">,</span> <span \
style="color: #304a96">NULL</span><span class="p">)));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">break</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">nullptr</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74588">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:53</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// It might be \
hard to detect the right GVariant type from</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">newline</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74589">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:63</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">switch</span> <span class="p">(</span><span \
class="n">g_variant_type_peek_string</span><span class="p">(</span><span \
class="n">g_variant_get_type</span><span class="p">(</span><span \
class="n">oldValue</span><span class="p">))[</span><span style="color: \
#601200">0</span><span class="p">])</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">case</span> <span style="color: \
#a0a000">G_VARIANT_CLASS_BOOLEAN</span><span class="p">:</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">newValue</span> <span style="color: #aa2211">=</span> <span \
class="n">g_variant_new_boolean</span><span class="p">(</span><span \
class="n">val</span><span class="p">.</span><span class="n">toBool</span><span \
class="p">());</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">indentation</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74590">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:73</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">newValue</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">g_settings_set_value</span><span class="p">(</span><span \
class="n">m_settings</span><span class="p">,</span> <span class="n">key</span><span \
class="p">.</span><span class="n">toLatin1</span><span class="p">().</span><span \
class="n">data</span><span class="p">(),</span> <span class="n">newValue</span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">braces</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74591">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:82</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span class="n">m_settings</span> <span \
style="color: #aa2211">=</span> <span class="n">g_settings_new_with_path</span><span \
class="p">(</span><span style="color: \
#766510">"org.freedesktop.pulseaudio.module-group"</span><span \
class="p">,</span> <span class="n">key</span><span class="p">.</span><span \
class="n">toLatin1</span><span class="p">().</span><span class="n">data</span><span \
class="p">());</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">newline</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74592">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.cpp:91</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">g_settings_sync</span><span class="p">();</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">m_settings</span><span \
class="p">)</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">g_object_unref</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">braces</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74582">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.h:34</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #a0a000">public</span><span class="p">:</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">explicit</span> <span class="n">GSettingsItem</span><span \
class="p">(</span><span style="color: #aa4000">const</span> <span \
class="n">QString</span> <span style="color: #aa2211">&</span><span \
class="n">key</span><span class="p">,</span> <span class="n">QObject</span> <span \
style="color: #aa2211">*</span><span class="n">parent</span> <span style="color: \
#aa2211">=</span> <span class="n">nullptr</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">newline</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74583">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.h:41</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #a0a000">Q_SIGNALS</span><span class="p">:</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">newline</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14147#inline-74584">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gsettingsitem.h:48</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #aa4000">static</span> <span style="color: #aa4000">void</span> <span \
style="color: #004012">settingChanged</span><span class="p">(</span><span \
class="n">GSettings</span> <span style="color: #aa2211">*</span><span \
class="n">settings</span><span class="p">,</span> <span style="color: \
#aa4000">const</span> <span class="n">gchar</span> <span style="color: \
#aa2211">*</span><span class="n">key</span><span class="p">,</span> <span \
class="n">gpointer</span> <span class="n">data</span><span class="p">)</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">move \
to .cpp</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14147#inline-74594">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">modulemanager.cpp:93</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#if \
<span class="bright">HAV</span>E_GCONF</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> \
</span><span class="n"><span class="bright">m_combineSinks</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">=</span></span><span class="bright"> </span><span style="color: \
#aa4000"><span class="bright">new</span></span><span class="bright"> </span><span \
class="n"><span class="bright">GConfModule</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span class="bright">"combine"</span></span><span \
class="bright"></span><span class="p"><span class="bright">),</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span \
class="bright">"module-combine"</span></span><span \
class="bright"></span><span class="p"><span class="bright">),</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">this</span></span><span class="bright"></span><span class="p"><span \
class="bright">);</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"> <span class="n">m_<span \
class="bright">switchOnConnect</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span style="color: #aa4000"><span class="bright">new</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">GConfModule</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">QStringLiteral</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"switch-on-connect"</span></span><span \
class="bright"></span><span class="p"><span class="bright">),</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span \
class="bright">"module-switch-on-connect</span>"</span><span \
class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #304a96">#if <span class="bright">US</span>E_GCONF<span \
class="bright"> || USE_GSETTINGS</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_<span \
class="bright">combineSinks</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span style="color: #aa4000"><span class="bright">new</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">ConfigModule</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">QStringLiteral</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"combine"</span></span><span class="bright"></span><span \
class="p"><span class="bright">),</span></span><span class="bright"> </span><span \
class="n"><span class="bright">QStringLiteral</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"module-combine</span>"</span><span class="p">),</span> \
<span style="color: #aa4000">this</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">newline</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14147">https://phabricator.kde.org/D14147</a></div></div><br \
/><div><strong>To: </strong>nicolasfella, drosca, davidedmundson<br /><strong>Cc: \
</strong>rikmills, broulik, asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic