[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       Henrik Fehlauer <noreply () phabricator ! kde ! org>
Date:       2018-07-15 22:14:19
Message-ID: 76757bb98a9526bfc06cf71b06c9c963 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

rkflx accepted this revision.
rkflx added a comment.


  @gregormi It's been a long time coming, but now the patch LGTM 👍 (BTW, the patch \
does not apply cleanly after recent changes in master, so make sure to rebase \
properly…)  
  @dhaumann As you "requested changes", could you check whether the patch is good to \
go now? (Currently Phabricator blocks landing the patch because of that.)  
  In D7087#292261 <https://phabricator.kde.org/D7087#292261>, @gregormi wrote:
  
  > What do you think about this minor layout change? It is noticeable when the \
window is resized horizontally. Instead of centering the grid's middle line, it makes \
the left and right padding space to the window border equal which looks more pleasing \
at least to my eye.  
  
  Yeah, I noticed this too. Much better after your update! It's slightly off-topic \
for the patch, but now that you added it, just keep it…  
  > For reference: the layout in master:
  
  Yup, your patch will be improving it quite a lot. You could add a small note to the \
summary to indicate you had to redo the layout a bit.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">rkflx accepted this revision.<br />rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><div><p><a href="https://phabricator.kde.org/p/gregormi/" style="  \
border-color: #f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@gregormi</a> It&#039;s been a long time coming, but \
now the patch LGTM 👍 (BTW, the patch does not apply cleanly after recent changes \
in master, so make sure to rebase properly…)</p>

<p><a href="https://phabricator.kde.org/p/dhaumann/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@dhaumann</a> As you &quot;requested changes&quot;, \
could you check whether the patch is good to go now? (Currently Phabricator blocks \
landing the patch because of that.)</p>

<blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7087#292261" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D7087#292261</a>, <a \
href="https://phabricator.kde.org/p/gregormi/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@gregormi</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>What do you think about this minor layout \
change? It is noticeable when the window is resized horizontally. Instead of \
centering the grid&#039;s middle line, it makes the left and right padding space to \
the window border equal which looks more pleasing at least to my eye.</p></div> \
</blockquote>

<p>Yeah, I noticed this too. Much better after your update! It&#039;s slightly \
off-topic for the patch, but now that you added it, just keep it…</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>For \
reference: the layout in master:</p></blockquote>

<p>Yup, your patch will be improving it quite a lot. You could add a small note to \
the summary to indicate you had to redo the layout a bit.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann, rkflx<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]